orpiske commented on a change in pull request #2540:
URL: https://github.com/apache/camel-k/pull/2540#discussion_r680946583
##########
File path: pkg/trait/logging.go
##########
@@ -90,8 +90,12 @@ func (l loggingTrait) Apply(environment *Environment) error {
if util.IsTrue(l.JsonPrettyPrint) {
envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleJsonPrettyPrint, True)
}
- } else if util.IsNilOrTrue(l.Color) {
- envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleColor, True)
+ } else {
+ envvar.SetVal(&environment.EnvVars,
envVarQuarkusLogConsoleJson, False)
Review comment:
I see your point and I think it makes sense. There is a risk, though.
Right now we add the required library for logging only if the [json flag is
true](https://github.com/apache/camel-k/blob/main/pkg/trait/logging.go#L76).
If we change that, we risk getting into a situation where Quarkus changes
the default logging behavior from plain text to json or some other
way/mechanism and we are left without control.
So, although this is very unlikely, I still think it would be better to be
explicit in this particular case, as we are talking about a core feature of the
integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
