dk2k commented on pull request #5856: URL: https://github.com/apache/camel/pull/5856#issuecomment-885516517
Removed warning message. As for unit tests. My changes do not introduce any new functionality and I don't think any relevant tests can be added. If user decides to specify his own KeyStore (creation of an instance of keystore is well documented and has about 10 detailed exceptions), it's their responsibility to have this instance properly filled. I don't have any idea on the content of this Keystore. It's sort of inversion of control aka dependency injection. I don't change the way this KeyStore is treated in the code of camel-api modile. I seen an analogy from hibernate - specify DataSource. Imagine that previously you could only specify a path in file system to a file with dataSource properties. And now you can construct an instance of DataSource yourself and pass it into hibernate. What can be additionally tested here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
