hokutor commented on a change in pull request #5753: URL: https://github.com/apache/camel/pull/5753#discussion_r660912549
########## File path: components/camel-huawei/camel-huaweicloud-obs/src/main/java/org/apache/camel/component/huaweicloud/obs/models/OBSRegion.java ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.huaweicloud.obs.models; + +import java.util.HashMap; +import java.util.Map; + +import org.apache.camel.util.ObjectHelper; + +/** + * Class containing Huawei Cloud OBS regions and endpoints + */ +public final class OBSRegion { Review comment: Thanks @davsclaus for the suggestion. For OBS alone, we use [a different cloud SDK](https://github.com/huaweicloud/huaweicloud-sdk-java-obs) whereas for other huawei cloud components, we have used [huaweicloud-sdk-java-v3](https://github.com/huaweicloud/huaweicloud-sdk-java-v3) . To be consistent with the [v3 sdk style of maintaining endpoints](https://github.com/huaweicloud/huaweicloud-sdk-java-v3/blob/master/services/functiongraph/src/main/java/com/huaweicloud/sdk/functiongraph/v2/region/FunctionGraphRegion.java), we decided to keep the similar pattern until v3 team comes up with support for OBS. Considering the potential mixed case problem, I have made it case insensitive to shield against different user behaviors in [this commit](https://github.com/apache/camel/pull/5753/commits/238b61819f1e86978b8abf5851b54b20a24b2883) and https://github.com/apache/camel/pull/5753/commits/6c471100cc2fc3a4827e3b6a24425f21e9926fa8 Let me know what you feel about this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
