astefanutti commented on a change in pull request #2464:
URL: https://github.com/apache/camel-k/pull/2464#discussion_r660807247
##########
File path: pkg/apis/camel/v1/integrationkit_types.go
##########
@@ -110,6 +110,8 @@ const (
IntegrationKitPhaseReady IntegrationKitPhase = "Ready"
// IntegrationKitPhaseError --
IntegrationKitPhaseError IntegrationKitPhase = "Error"
+ // IntegrationKitPhaseCannotBuild
+ IntegrationKitPhaseCannotBuild IntegrationKitPhase = "Cannot Build"
Review comment:
I see, though this only happens when the IntegrationKit digest changes,
which I think makes it acceptable. Ideally, IntegrationKit API would mirror the
Build API, which has a `Failed` phase for recoverable issues, and an `Error`
phase for unrecoverable ones. Still I'd rather re-use the
`IntegrationKitPhaseError` in that case, instead of introducing a very specific
`IntegrationKitPhaseCannotBuild` phase. If you think that a phase for
unrecoverable error is mandatory, then I would suggest mirroring the Build API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
