ppalaga commented on a change in pull request #2859: URL: https://github.com/apache/camel-quarkus/pull/2859#discussion_r660723086
########## File path: extensions/avro-rpc/runtime/src/main/java/org/apache/camel/quarkus/component/avro/rpc/spi/VertxHttpServer.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.avro.rpc.spi; + +import io.quarkus.arc.Arc; +import io.vertx.core.Vertx; +import io.vertx.core.buffer.Buffer; +import org.apache.avro.AvroRuntimeException; +import org.apache.avro.ipc.Responder; +import org.apache.avro.ipc.ResponderServlet; +import org.apache.avro.ipc.Server; + +public class VertxHttpServer implements Server { + + private int port; + + private Responder responder; + + public VertxHttpServer(Responder servletAvro, int port) { + this.port = port; + this.responder = servletAvro; + } + + @Override + public int getPort() { + return port; + } + + @Override + public void start() { + Vertx vertx = Arc.container().instance(Vertx.class).get(); + + vertx.createHttpServer().requestHandler(rc -> { + rc.bodyHandler(handler -> { + HttpServletRequestFromBytes req = new HttpServletRequestFromBytes(handler.getBytes(), rc.method().name()); + HttpServletResponseWithBytes resp = new HttpServletResponseWithBytes(); + + try { + new ResponderServlet(responder).service(req, resp); Review comment: org.apache.avro.ipc.ResponderServlet should be stateless, so one instance per VertxHttpServer should be enough, no? ########## File path: extensions/avro-rpc/runtime/src/main/java/org/apache/camel/quarkus/component/avro/rpc/spi/HttpServletResponseWithBytes.java ########## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.avro.rpc.spi; + +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.io.PrintWriter; +import java.util.Collection; +import java.util.Locale; + +import javax.servlet.ServletOutputStream; +import javax.servlet.WriteListener; +import javax.servlet.http.Cookie; +import javax.servlet.http.HttpServletResponse; + +/** + * Empty implementation of {@link javax.servlet.http.HttpServletResponse}. + * Serves as a wrapper to be used for {@link org.apache.avro.ipc.ResponderServlet}. + */ +public class HttpServletResponseWithBytes implements HttpServletResponse { + + private ServletOutputStreamWithBytes baos = new ServletOutputStreamWithBytes(); + + public byte[] getBytes() { + return baos.getBytes(); + } + + @Override + public ServletOutputStream getOutputStream() throws IOException { + return baos; + } + + @Override + public void addCookie(Cookie cookie) { + + } + + // --------------------- following methods are not implemented and not used ---------------------------- + + @Override + public boolean containsHeader(String s) { + return false; Review comment: Maybe better throw an UnsupportedOperationException here and below? ########## File path: extensions/avro-rpc/deployment/src/main/java/org/apache/camel/quarkus/component/avro/rpc/deployment/AvroRpcProcessor.java ########## @@ -37,7 +41,8 @@ FeatureBuildItem feature() { } @BuildStep - ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem combinedIndex) { + ReflectiveClassBuildItem registerForReflection(CombinedIndexBuildItem combinedIndex, + BuildProducer<ReflectiveClassBuildItem> reflectiveClassProducer) { Review comment: reflectiveClassProducer does not seem to be used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
