aldettinger commented on a change in pull request #2818:
URL: https://github.com/apache/camel-quarkus/pull/2818#discussion_r655579122
##########
File path: integration-test-groups/foundation/core/pom.xml
##########
@@ -43,13 +43,12 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
</dependency>
-
- <!-- test dependencies -->
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-junit5</artifactId>
- <scope>test</scope>
</dependency>
Review comment:
Yeah, keeping only JUnit 5 deps in compile may also be a candidate. I
know we have already some test serializing object to JSON but then there is
this case where quarkus-jackson register those object for reflection and can
falsify test result.
In this case, let me see if I can come up with something like
toString()/fromString() method.
##########
File path: integration-test-groups/foundation/core/pom.xml
##########
@@ -43,13 +43,12 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
</dependency>
-
- <!-- test dependencies -->
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-junit5</artifactId>
- <scope>test</scope>
</dependency>
Review comment:
so, I've updated the bean with the toString() so poms are not changed.
##########
File path: integration-test-groups/foundation/core/pom.xml
##########
@@ -43,13 +43,12 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
</dependency>
-
- <!-- test dependencies -->
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-junit5</artifactId>
- <scope>test</scope>
</dependency>
Review comment:
so, I've updated the beans with the toString() so poms are not changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
