electrosaur commented on a change in pull request #5617:
URL: https://github.com/apache/camel/pull/5617#discussion_r643816975



##########
File path: 
components/camel-google/camel-google-pubsub/src/main/java/org/apache/camel/component/google/pubsub/GooglePubsubConsumer.java
##########
@@ -177,6 +178,12 @@ private void synchronousPull(String subscriptionName) {
                     }
                 } catch (IOException e) {
                     localLog.error("Failure getting messages from PubSub", e);
+                } catch (ApiException e) {

Review comment:
       @omarsmak Yes, all of the 5xx errors are retryable per 
https://cloud.google.com/pubsub/docs/reference/error-codes. I initially thought 
of checking if `e.getStatusCode()` was 5xx, but this seemed better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to