mroldan747 commented on pull request #5602:
URL: https://github.com/apache/camel/pull/5602#issuecomment-848562470


   > > Looks good to me, just curious about why you switched from 
HazelcastTestSupport to CamelTestSupport directly. It's fine, but I think it 
makes sense to use the same approach on all the tests.
   > 
   > I started that here
   > 
   > 
https://github.com/apache/camel/blob/c94f811ea315cf7a603ea08e5f67643df230242b/components/camel-hazelcast/src/test/java/org/apache/camel/component/hazelcast/HazelcastReplicatedmapConsumerTest.java#L38
   > 
   > , the idea was not to have those methods related to mock. But now there 
are 3 classes extending CamelTestSupport directly.
   > As a follow up I created this JIRA 
https://issues.apache.org/jira/browse/CAMEL-16660, to make HazelcastTestSupport 
use camel-test-infra-Hazelcast
   
    I can follow up with this new JIRA, to fix the usage of CamelTestSupport, 
unless it is blocking for this PR ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to