astefanutti commented on pull request #2284:
URL: https://github.com/apache/camel-k/pull/2284#issuecomment-843099563


   @phantomjinx wow, that looks fantastic! I love how you addressed patching, 
Role (resp. RoleBinding) auto-promoting to ClusterRole (resp. 
ClusterRoleBinding), and that you fixed #2167 in the process 👍🏼.
   
   I'd like to test it locally to give you more feedback on the Kustomize 
directory structure, even if that looks great at first glance.  But if you 
prefer, we can have this merged once CI is green, and iterate later on. 
Whatever option we choose, may I suggest to create a new GitHub Actions 
workflow called `kustomize`, that would install Camel K with plain `kustomize`, 
and run some tests. Ideally, If we were confident enough, we could even migrate 
an existing workflow to using plain `kustomize`, but that would require to 
refactor the way Camel K is installed from the tests themselves.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to