[GitHub] [camel] davsclaus commented on a change in pull request #5372: [CAMEL-16504] YAML Dsl : support for "flow" like route definition

[GitBox]

davsclaus commented on a change in pull request #5372:
URL: https://github.com/apache/camel/pull/5372#discussion_r613822471



##########
File path: 
dsl/camel-yaml-dsl/camel-yaml-dsl/src/main/java/org/apache/camel/dsl/yaml/YamlRoutesBuilderLoader.java
##########
@@ -57,39 +61,46 @@ protected void doBuild() throws Exception {
         super.doBuild();
 
         this.settings = LoadSettings.builder().build();
-        this.constructor = new YamlDeserializationContext(settings);
-        this.constructor.setCamelContext(getCamelContext());
-        this.constructor.addResolvers(new CustomResolver());
-        this.constructor.addResolvers(new ModelDeserializersResolver());
-        this.constructor.addResolvers(new 
EndpointProducerDeserializersResolver());
+        this.deserializationContext = new YamlDeserializationContext(settings);
+        this.deserializationContext.setCamelContext(getCamelContext());
+        this.deserializationContext.addResolvers(new CustomResolver());
+        this.deserializationContext.addResolvers(new 
ModelDeserializersResolver());
+        this.deserializationContext.addResolvers(new 
EndpointProducerDeserializersResolver());
+
+        final Map<String, String> options = 
getCamelContext().getGlobalOptions();

Review comment:
       I wonder if the mode should be set later, eg in doInit or something, as 
potentially the end user may configure the mode on camel context global options 
at some point later, than this class may be created.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org