omarsmak commented on a change in pull request #5312:
URL: https://github.com/apache/camel/pull/5312#discussion_r610531608



##########
File path: 
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaProducer.java
##########
@@ -189,6 +196,7 @@ public boolean hasNext() {
                     String innerTopic = msgTopic;
                     Object innerKey = null;
                     Integer innerPartitionKey = null;
+                    Long innerTimestamp = null;

Review comment:
       I have a mix feeling of altering this behavior, in case of topic, it 
would make sense to fallback to the outer topic since you need to specify a 
topic. However, in case of the timestamp, this is not mandatory per say to 
specify and thus it would be fine to have it as `null`. Also, altering the 
timestamp for these messages, IMHO would alter the semantics of in case you 
deliberately don't want to specify timestamp for some of these inner messages. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to