davsclaus commented on a change in pull request #5299:
URL: https://github.com/apache/camel/pull/5299#discussion_r607784012
##########
File path:
components/camel-jsonpath/src/main/java/org/apache/camel/jsonpath/JsonPathEngine.java
##########
@@ -182,14 +182,30 @@ private Object doRead(String path, Exchange exchange)
throws IOException, CamelE
return JsonPath.using(configuration).parse(list).read(path);
} else {
// can we find an adapter which can read the message body/header
- Object answer = readWithAdapter(path, exchange);
+ Object answer = null;
Review comment:
I would like to see if we can find a solution without catching a runtime
exception and then try again with stream mode.
Instead we should probably check the exchange body and find the right read
method to use from the start.
Any processing that causes an exception to be swallowed is a bad smell and
also a performance overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
