[camel] 06/09: Camel-AWS2-Lambda: Producer operations refactoring - deleteAlias

[acosentino]

This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit a92cbdf0a10830096ebd08c0fb97da1d16593944
Author: Andrea Cosentino <anco...@gmail.com>
AuthorDate: Wed Mar 31 11:22:45 2021 +0200

    Camel-AWS2-Lambda: Producer operations refactoring - deleteAlias
---
 .../component/aws2/lambda/Lambda2Producer.java     | 28 ++++++++--------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git 
a/components/camel-aws/camel-aws2-lambda/src/main/java/org/apache/camel/component/aws2/lambda/Lambda2Producer.java
 
b/components/camel-aws/camel-aws2-lambda/src/main/java/org/apache/camel/component/aws2/lambda/Lambda2Producer.java
index 3cda5e8..8d4efa1 100644
--- 
a/components/camel-aws/camel-aws2-lambda/src/main/java/org/apache/camel/component/aws2/lambda/Lambda2Producer.java
+++ 
b/components/camel-aws/camel-aws2-lambda/src/main/java/org/apache/camel/component/aws2/lambda/Lambda2Producer.java
@@ -647,36 +647,28 @@ public class Lambda2Producer extends DefaultProducer {
     }
 
     private void deleteAlias(LambdaClient lambdaClient, Exchange exchange) 
throws InvalidPayloadException {
+       DeleteAliasRequest request = null;
+       DeleteAliasResponse result;
         if (getConfiguration().isPojoRequest()) {
-            Object payload = exchange.getIn().getMandatoryBody();
-            if (payload instanceof DeleteAliasRequest) {
-                DeleteAliasResponse result;
-                try {
-                    result = lambdaClient.deleteAlias((DeleteAliasRequest) 
payload);
-                } catch (AwsServiceException ase) {
-                    LOG.trace("deleteAlias command returned the error code 
{}", ase.awsErrorDetails().errorCode());
-                    throw ase;
-                }
-                Message message = getMessageForResponse(exchange);
-                message.setBody(result);
-            }
+            request = 
exchange.getIn().getMandatoryBody(DeleteAliasRequest.class);
         } else {
-            DeleteAliasResponse result;
-            try {
-                DeleteAliasRequest.Builder request = 
DeleteAliasRequest.builder().functionName(getEndpoint().getFunction());
+                DeleteAliasRequest.Builder builder = 
DeleteAliasRequest.builder();
+                builder.functionName(getEndpoint().getFunction());
                 String aliasName = 
exchange.getIn().getHeader(Lambda2Constants.FUNCTION_ALIAS_NAME, String.class);
                 if (ObjectHelper.isEmpty(aliasName)) {
                     throw new IllegalArgumentException("Function alias must be 
specified to delete an alias");
                 }
-                request.name(aliasName);
-                result = lambdaClient.deleteAlias(request.build());
+                builder.name(aliasName);
+                request = builder.build();
+        }
+        try  {
+                result = lambdaClient.deleteAlias(request);
             } catch (AwsServiceException ase) {
                 LOG.trace("deleteAlias command returned the error code {}", 
ase.awsErrorDetails().errorCode());
                 throw ase;
             }
             Message message = getMessageForResponse(exchange);
             message.setBody(result);
-        }
     }
 
     private void getAlias(LambdaClient lambdaClient, Exchange exchange) throws 
InvalidPayloadException {