[GitHub] [camel-kafka-connector] tadayosi commented on a change in pull request #1111: NetworkUtils should be able to hold a free port for later usage #1109

[GitBox]

tadayosi commented on a change in pull request #1111:
URL: 
https://github.com/apache/camel-kafka-connector/pull/1111#discussion_r596534616



##########
File path: 
tests/itests-common/src/test/java/org/apache/camel/kafkaconnector/common/utils/NetworkUtils.java
##########
@@ -29,10 +29,11 @@
 import org.slf4j.LoggerFactory;
 
 public final class NetworkUtils {
-    public static final int  DEFAULT_STARTING_PORT = 49152;
+    
     public static final int  DEFAULT_ENDING_PORT = 65535;
     private static String hostname;
 
+    public static int  DEFAULT_STARTING_PORT = 49152;

Review comment:
       I'd keep `DEFAULT_STARTING_PORT` as `static final int` and declare 
another `static int startingPort` for actually using it in the code. There is 
also a style error that all uppercase variables need to be declared before 
lowercase variables.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org