squakez commented on a change in pull request #2114:
URL: https://github.com/apache/camel-k/pull/2114#discussion_r593180377



##########
File path: pkg/util/kubernetes/util.go
##########
@@ -228,3 +232,37 @@ func ResolveValueSource(ctx context.Context, client 
k8sclient.Reader, namespace
 
        return "", nil
 }
+
+// GetTolerations build an array of Tolerations from an array of string
+func GetTolerations(taints []string) ([]corev1.Toleration, error) {

Review comment:
       Haha, yeah, those are valid points too. With 8118aae I tried to refactor 
in order to have a tidier organization. I am not entirely sure about the names 
though. What do you think @astefanutti?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to