zregvart commented on pull request #537:
URL: https://github.com/apache/camel-website/pull/537#issuecomment-778259045


   I think overall the only authoritative preview will be the one done on the 
camel-website repository, no other preview will be up to date or as involved as 
the one in the camel-website repository. If building the antora-camel-ui or 
using a custom Antora playbook was an issue then I could reconsider this, but I 
don't see it as an issue. On the other hand I see a number of issues if we do 
releases of antora-camel-ui, spanning from that UI being only a part of the 
overall Antora configuration (we have 
[patches](https://github.com/apache/camel-website/blob/32188349a4e0f3c411d6e97ca92b6f733d67849c/package.json#L6),
 [extensions and 
attributes](https://github.com/apache/camel-website/blob/32188349a4e0f3c411d6e97ca92b6f733d67849c/antora-playbook.yml#L90-L97)),
 specific Antora version. All that would need to be duplicated for the preview 
to be relevant. I would also maintain that the policy on releasing to GitHub 
releases is not in place or has been discussed, there is an area for confusion
  here, whereby someone might mistake this for an official ASF release, which 
for licensing reason and project charter reasons (not really a part of Camel 
distribution), I maintain, cannot be done.
   
   So instead of doing this, I suggest working from the camel-website 
repository, copy the `antora-playbook.yml`, for faster tunraround remove all 
but needed content sources, point to local repositories as needed, and work 
with the `yarn preview` support we have here. That way any changes that would 
need to go into the antora-ui-camel can be previewed locally. This is how I 
work and the turnaround is ~15-20 sec at the most. We can certainly improve 
this workflow, i.e. preview could also auto-rebuild the antora-ui-camel, look 
for (say) custom-antora-playbook.yml and use that instead, watch the local 
content source repositories and rebuild on changes there and such, but this 
hasn't been on the top of my list as invoking `(cd antora-ui-camel; yarn build) 
&& yarn build:antora` (for a subset of content sources), gives me really quick 
turnaround.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to