jamesnetherton commented on a change in pull request #2186:
URL: https://github.com/apache/camel-quarkus/pull/2186#discussion_r568427994
##########
File path: docs/modules/ROOT/pages/reference/extensions/xmlsecurity.adoc
##########
@@ -33,3 +33,14 @@ Please refer to the above links for usage and configuration
details.
----
Check the xref:user-guide/index.adoc[User guide] for more information about
writing Camel Quarkus applications.
+
+== Camel Quarkus limitations
+
+There is currently no native mode support for XSLT based transform methods on
the `xmlsecurity` producer via the `transformMethods` URI option.
+
Review comment:
I didn't really want to go into the specifics of the problems in the
README. But the native build will fail since there is some missing reflective
class config + some other bits. I described the problem (very) briefly in
https://github.com/apache/camel-quarkus/issues/2185.
##########
File path:
integration-tests/xmlsecurity/src/main/resources/application.properties
##########
@@ -0,0 +1,17 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+quarkus.camel.native.resources.include-patterns=*.xsl
Review comment:
Yes, I actually forgot it had been added to Quarkus core (I guess this
can be closed now https://github.com/apache/camel-quarkus/issues/988).
Maybe we should update all of the tests to use it and deprecate the old
config properties? I hate it when we have multiple ways of doing the same thing.
##########
File path:
integration-tests/xmlsecurity/src/main/resources/application.properties
##########
@@ -0,0 +1,17 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+quarkus.camel.native.resources.include-patterns=*.xsl
Review comment:
Yes, I actually forgot it had been added to Quarkus core (I guess this
can be closed now https://github.com/apache/camel-quarkus/issues/988).
Maybe we should update all of the tests to use it and deprecate (maybe just
remove?) the old config properties? I hate it when we have multiple ways of
doing the same thing.
##########
File path:
integration-tests/xmlsecurity/src/main/resources/application.properties
##########
@@ -0,0 +1,17 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+quarkus.camel.native.resources.include-patterns=*.xsl
Review comment:
Yes, I actually forgot it had been added to Quarkus core.
Maybe we should update all of the tests to use it and deprecate (maybe just
remove?) the old config properties? I hate it when we have multiple ways of
doing the same thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
