johnpoth commented on a change in pull request #1952:
URL: https://github.com/apache/camel-k/pull/1952#discussion_r566849781



##########
File path: pkg/controller/integration/integration_controller.go
##########
@@ -217,6 +218,15 @@ func add(mgr manager.Manager, r reconcile.Reconciler) 
error {
                return err
        }
 
+       // Watch ServiceBindings created
+       err = c.Watch(&source.Kind{Type: &sb.ServiceBinding{}}, 
&handler.EnqueueRequestForOwner{

Review comment:
       Ah right no not by labels, here's a sample secret:
   ```
   apiVersion: v1
   data:
    ...
   kind: Secret
   metadata:
     name: sample-service-binding-request
     namespace: service-binding
     ownerReferences:
     - apiVersion: operators.coreos.com/v1alpha1
       controller: true
       kind: ServiceBinding
       name: sample-service-binding-request
     selfLink: 
/api/v1/namespaces/service-binding/secrets/sample-service-binding-request
   type: Opaque
   ```
   We could check in the owner references and work our way up to the 
integration name by checking if it exists but it may be simpler to file a 
request on the Service Binding Operator side to copy labels from the 
`ServiceBinding` to the generated `Secret` which seems at first glance like a 
reasonable request...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to