oscerd commented on a change in pull request #4952:
URL: https://github.com/apache/camel/pull/4952#discussion_r566059653
##########
File path:
components/camel-aws-s3/src/main/java/org/apache/camel/component/aws/s3/S3Consumer.java
##########
@@ -66,9 +67,12 @@ protected int poll() throws Exception {
String fileName = getConfiguration().getFileName();
String bucketName = getConfiguration().getBucketName();
+ String doneFileName = getConfiguration().getDoneFileName();
Queue<Exchange> exchanges;
- if (fileName != null) {
+ if (shouldSkipCauseDoneFileIsConfiguredButMissing(bucketName,
doneFileName)) {
Review comment:
Naming is hard but this name is really long :-D
##########
File path:
components/camel-aws-s3/src/main/java/org/apache/camel/component/aws/s3/S3Consumer.java
##########
@@ -16,19 +16,11 @@
*/
package org.apache.camel.component.aws.s3;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.LinkedList;
-import java.util.List;
-import java.util.Queue;
+import java.util.*;
import com.amazonaws.AmazonClientException;
import com.amazonaws.services.s3.AmazonS3;
-import com.amazonaws.services.s3.model.GetObjectRequest;
-import com.amazonaws.services.s3.model.ListObjectsRequest;
-import com.amazonaws.services.s3.model.ObjectListing;
-import com.amazonaws.services.s3.model.S3Object;
-import com.amazonaws.services.s3.model.S3ObjectSummary;
+import com.amazonaws.services.s3.model.*;
Review comment:
Same
##########
File path:
components/camel-aws-s3/src/main/java/org/apache/camel/component/aws/s3/S3Consumer.java
##########
@@ -16,19 +16,11 @@
*/
package org.apache.camel.component.aws.s3;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.LinkedList;
-import java.util.List;
-import java.util.Queue;
+import java.util.*;
Review comment:
Please avoid * imports
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
