This is an automated email from the ASF dual-hosted git repository.
acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push:
new 5224b17 CAMEL-16001 - Fixed CS
5224b17 is described below
commit 5224b17da8006bcb1c4c1fadc61f39455ebf9278
Author: Andrea Cosentino <anco...@gmail.com>
AuthorDate: Thu Jan 28 08:29:35 2021 +0100
CAMEL-16001 - Fixed CS
---
.../smn/SimpleNotificationEndpoint.java | 2 +-
.../huaweicloud/smn/SimpleNotificationUtils.java | 2 +-
.../huaweicloud/smn/constants/SmnConstants.java | 6 ++--
.../huaweicloud/smn/constants/SmnOperations.java | 7 +++--
.../huaweicloud/smn/constants/SmnProperties.java | 25 +++++++++++++---
.../huaweicloud/smn/constants/SmnServices.java | 6 ++--
.../src/test/resources/log4j2.properties | 33 +++++++++++-----------
.../test/resources/testconfiguration.properties | 33 +++++++++++-----------
8 files changed, 67 insertions(+), 47 deletions(-)
diff --git
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationEndpoint.java
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationEndpoint.java
index 60145a4..91a14c3 100644
---
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationEndpoint.java
+++
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationEndpoint.java
@@ -90,7 +90,7 @@ public class SimpleNotificationEndpoint extends
DefaultEndpoint {
@UriParam(description = "Ignore SSL verification", displayName = "SSL
Verification Ignored", secret = false,
defaultValue = "false")
@Metadata(required = false)
- private boolean ignoreSslVerification = false;
+ private boolean ignoreSslVerification;
private SmnClient smnClient;
diff --git
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationUtils.java
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationUtils.java
index 1c8ac33..874cb90 100644
---
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationUtils.java
+++
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationUtils.java
@@ -25,7 +25,7 @@ import org.slf4j.LoggerFactory;
/**
* utility functions for the component
*/
-public class SimpleNotificationUtils {
+public final class SimpleNotificationUtils {
private static final Logger LOG =
LoggerFactory.getLogger(SimpleNotificationUtils.class.getName());
private SimpleNotificationUtils() {
diff --git
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnConstants.java
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnConstants.java
index 1fb0c0a..4cd37d6 100644
---
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnConstants.java
+++
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnConstants.java
@@ -16,10 +16,10 @@
*/
package org.apache.camel.component.huaweicloud.smn.constants;
-public class SmnConstants {
+public final class SmnConstants {
+
+ public static final String TOPIC_URN_FORMAT = "urn:smn:%s:%s:%s";
private SmnConstants() {
}
-
- public static final String TOPIC_URN_FORMAT = "urn:smn:%s:%s:%s";
}
diff --git
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnOperations.java
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnOperations.java
index 4f1c399..32ec6c9 100644
---
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnOperations.java
+++
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnOperations.java
@@ -16,11 +16,12 @@
*/
package org.apache.camel.component.huaweicloud.smn.constants;
-public class SmnOperations {
+public final class SmnOperations {
+
+ public static final String PUBLISH_AS_TEMPLATED_MESSAGE =
"publishAsTemplatedMessage";
+ public static final String PUBLISH_AS_TEXT_MESSAGE =
"publishAsTextMessage";
private SmnOperations() {
}
- public static final String PUBLISH_AS_TEXT_MESSAGE =
"publishAsTextMessage";
- public static final String PUBLISH_AS_TEMPLATED_MESSAGE =
"publishAsTemplatedMessage";
}
diff --git
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnProperties.java
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnProperties.java
index 5c1b64c..472d624 100644
---
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnProperties.java
+++
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnProperties.java
@@ -1,9 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
package org.apache.camel.component.huaweicloud.smn.constants;
-public class SmnProperties {
-
- public SmnProperties() {
- }
+public final class SmnProperties {
// request properties
public static final String TEMPLATE_NAME = "CamelHwCloudSmnTemplateName";
@@ -16,4 +29,8 @@ public class SmnProperties {
//response properties
public static final String SERVICE_MESSAGE_ID =
"CamelHwCloudSmnMesssageId";
public static final String SERVICE_REQUEST_ID = "CamelHwCloudSmnRequestId";
+
+ private SmnProperties() {
+ }
+
}
diff --git
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnServices.java
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnServices.java
index e68fc5e..a63f834 100644
---
a/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnServices.java
+++
b/components/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/constants/SmnServices.java
@@ -16,10 +16,10 @@
*/
package org.apache.camel.component.huaweicloud.smn.constants;
-public class SmnServices {
+public final class SmnServices {
+
+ public static final String PUBLISH_MESSAGE = "publishMessageService";
private SmnServices() {
}
-
- public static final String PUBLISH_MESSAGE = "publishMessageService";
}
diff --git
a/components/camel-huaweicloud-smn/src/test/resources/log4j2.properties
b/components/camel-huaweicloud-smn/src/test/resources/log4j2.properties
index abf6bc4..d9f0508 100644
--- a/components/camel-huaweicloud-smn/src/test/resources/log4j2.properties
+++ b/components/camel-huaweicloud-smn/src/test/resources/log4j2.properties
@@ -1,19 +1,20 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
appender.out.type = Console
appender.out.name = out
appender.out.layout.type = PatternLayout
diff --git
a/components/camel-huaweicloud-smn/src/test/resources/testconfiguration.properties
b/components/camel-huaweicloud-smn/src/test/resources/testconfiguration.properties
index 06bb4a3..9b31cf1 100644
---
a/components/camel-huaweicloud-smn/src/test/resources/testconfiguration.properties
+++
b/components/camel-huaweicloud-smn/src/test/resources/testconfiguration.properties
@@ -1,19 +1,20 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
## Test configurations
authKey=dummy_auth_key
secretKey=dummy_secret_key
