tadayosi commented on pull request #1850:
URL: https://github.com/apache/camel-k/pull/1850#issuecomment-741640972


   @astefanutti I spotted the underlying issue here. So as I understand it it's 
essentially how mapstructure handles bool struct properties when they are 
annotated with `omitempty`.
   https://github.com/tadayosi/samples-go/blob/master/pkg/mapper/mapper_test.go
   
   I thought that `BaseTrait.Enabled` is originally typed as `*bool` because 
the author already noticed the limitation when creating it. If that's true I 
think it's natural that we all follow the rule of using `*bool` for all bool 
trait props.
   https://github.com/apache/camel-k/blob/master/pkg/trait/trait_types.go#L133


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to