fvaleri commented on pull request #752: URL: https://github.com/apache/camel-kafka-connector/pull/752#issuecomment-735653258
> @oscerd @valdar I believe you both have better understanding of the ramifications of this than I do. At first sight I have no objections with the approach, but I would kindly ask for one more thing. > > Do we have to update the [missing dependencies part](https://github.com/apache/camel-kafka-connector/blob/master/docs/modules/ROOT/pages/troubleshooting.adoc) of the troubleshooting guide as part of this? > > My understanding is that we do need to update the note there. Therefore, I would probably just put a note saying "From version 0.x.x and forward the JMS dependencies are packaged along w/ sjms2 and this should not be a problem. Should you need to use other JMS clients, you need to repackage or use the legacy/regular/etc JMS component". +1 for this, thanks @orpiske. In general I think that trying to avoid the need to repackage is the best strategy for a great user experience. Let me know if you want me to add this note to the commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
