JiriOndrusek opened a new pull request #2025:
URL: https://github.com/apache/camel-quarkus/pull/2025


   fixes: https://github.com/apache/camel-quarkus/issues/1941
   
   Change overrides version of avro dependencies from 1.9.1 (camel) to 1.10.0 
(used by quarkus). Once issue https://issues.apache.org/jira/browse/CAMEL-15879 
is solved, restriction could be removed. But version has to be still aligned 
manually, because camel uses dependencies like `avro-ipc*`, which are not used 
in quarkus.
   
   There is a "questionable" substitution - `GenericDatumReaderSubstitute`.
   As you can see, there is a method `getStringClass` in avro (see 
https://github.com/apache/avro/blob/branch-1.10/lang/java/avro/src/main/java/org/apache/avro/generic/GenericDatumReader.java#L503),
 which uses local cache created right during instantiation (see 
https://github.com/apache/avro/blob/branch-1.10/lang/java/avro/src/main/java/org/apache/avro/generic/GenericDatumReader.java#L500).
   This cache is **null** (in some tests) during execution in native mode. I 
don't see how this is possible. But I've created substitution, which creates 
this cache if it is null. With this substitution tests are successful. (but I 
still think that it should work without this substitution, which obviously does 
not)
   From my POV it could be nice, to create a separate issue to investigate this 
behavior. WDYT? 
     
   
   
   [ ] An issue should be filed for the change unless this is a trivial change 
(fixing a typo or similar). One issue should ideally be fixed by not more than 
one commit and the other way round, each commit should fix just one issue, 
without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly 
spelled subject line and body. Copying the title of the associated issue is 
typically enough. Please include the issue number in the commit message 
prefixed by #.
   [ ] The pull request description should explain what the pull request does, 
how, and why. If the info is available in the associated issue or some other 
external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close 
the named issue upon merging the pull request. Using them is typically a good 
idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if 
necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: 
https://camel.apache.org/camel-quarkus/latest/contributor-guide.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to