omarsmak commented on a change in pull request #4630:
URL: https://github.com/apache/camel/pull/4630#discussion_r527037242



##########
File path: 
components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/processor/JsonRestProcessor.java
##########
@@ -100,7 +101,11 @@ protected void processRequest(Exchange exchange) throws 
SalesforceException {
 
             case SEARCH:
                 // handle known response type
-                exchange.setProperty(RESPONSE_TYPE, 
TypeReferences.SEARCH_RESULT_TYPE);
+                if 
(Double.parseDouble(endpoint.getConfiguration().getApiVersion()) >= 37.0) {

Review comment:
       ah sorry didn't realize that, you are right, only the version need to be 
extracted. Anyway, if you can't find a some meaningful naming, is also fine 
like this as long not much of duplications happening, just wanted to avoid the 
magic number ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to