[GitHub] [camel-quarkus] davsclaus commented on a change in pull request #1984: Fixing core build because of recent changes in camel master

[GitBox]

davsclaus commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517209261



##########
File path: 
extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/FastCamelContext.java
##########
@@ -344,10 +345,11 @@ protected HeadersMapFactory createHeadersMapFactory() {
 
     @Override
     protected BeanProxyFactory createBeanProxyFactory() {
-        return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, 
BeanProxyFactory.class)
-                .resolve(getCamelContextReference())
-                .orElseThrow(() -> new IllegalArgumentException("Cannot find 
BeanProxyFactory on classpath. "
-                        + "Add camel-bean to classpath."));
+        return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, 
BeanProxyFactory.class,
+                getFactoryFinder(FactoryFinder.DEFAULT_PATH))

Review comment:
       That should be getBootstrapFactoryFinder for all these kinds where they 
are resolved once during bootstapping. The same for the other places where you 
changed.
   
   Thanks for fixing this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org