doru1004 commented on a change in pull request #1777:
URL: https://github.com/apache/camel-k/pull/1777#discussion_r512983038
##########
File path: pkg/builder/builder_steps.go
##########
@@ -140,7 +141,17 @@ func generateProjectSettings(ctx *Context) error {
func injectDependencies(ctx *Context) error {
// Add dependencies from build
- for _, d := range ctx.Build.Dependencies {
+ return InjectDependenciesCommon(&ctx.Maven.Project,
ctx.Build.Dependencies, ctx.Catalog)
+}
+
+// InjectDependenciesCommon --
+func InjectDependenciesCommon(
Review comment:
I think this function belongs in a utils file rather than here. It
performs a role that is independent of anything other than a Maven project +
Dependencies + Catalog which don't necessarily have to be inside the builder.
I've moved the function to a new file under utils/camel. I have also moved the
function which sanitizes integration dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
