zregvart edited a comment on pull request #4514: URL: https://github.com/apache/camel/pull/4514#issuecomment-716530251
TLDR, I think this should be done within the existing composite API code. If it remains as is, we will have to maintain two different composite API implementations and two different user experiences. What we have currently is support for: - `composite` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_composite.htm) - `composite-tree` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_sobject_tree.htm) - `composite-batch` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_batch.htm) This PR adds support for: - upsert functionality of composite collections (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_sobjects_collections_upsert.htm) I think we need to be consistent with existing implementation to help minimize the maintenance effort, and consistent with the user experience. To that end: - I'd like to see this incorporated within the composite support we already have: [CompositeApiProcessor](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/processor/CompositeApiProcessor.java), [CompositeApiClient](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/client/CompositeApiClient.java) and [DefaultCompositeApiClient](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/client/DefaultCompositeApiClient.java). - The operation should be named something like `composite-collections-upsert` or `composite-collections` with auto-detection (if possible) of sub-operation (create, retreive, update, upsert, delete). - I'd also like to see full support for composite collections (can be done over multiple contributions). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
