davsclaus commented on pull request #4414:
URL: https://github.com/apache/camel/pull/4414#issuecomment-706971966
> I have still some doubts.
>
> * `isInstance` method expects instance object, but you are passing
`Class`. Your condition will be always false. Can you fix that and also please
add unit test to see if this PR actually fixes the the issue, as currently it
does not, your code is never hitted.
> * What hapens with String beans? Eg something like this will probably not
work once you fix the previous point. It will just return `#myJmsUsername`
without resolving that to `brokerUserName` String.
>
> ```
> @BindToRegistry("myJmsUsername")
> String myJmsUsername = "brokerUserName";
>
> from(jms(...).username("#myJmsUsername"));
> ```
The endpointdsl works differently for those simple types. This problem is
for complex object types that are set as additional parameters form the uri
(special for endpoint dsl).
So this PR is in the right direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
