davsclaus commented on a change in pull request #4384:
URL: https://github.com/apache/camel/pull/4384#discussion_r501562424
##########
File path:
components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitConsumer.java
##########
@@ -326,9 +340,13 @@ public void reconnect() throws Exception {
} else if (channel == null || !isAutomaticRecoveryEnabled()) {
LOG.info("Attempting to open a new rabbitMQ channel");
Connection conn = consumer.getConnection();
- channel = openChannel(conn);
- // Register the channel to the tag
- start();
+ try {
+ stop();
Review comment:
Just wonder what to do if stop throw an exception, should we silently
ignore this?
##########
File path:
components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/RabbitConsumer.java
##########
@@ -326,9 +340,13 @@ public void reconnect() throws Exception {
} else if (channel == null || !isAutomaticRecoveryEnabled()) {
LOG.info("Attempting to open a new rabbitMQ channel");
Connection conn = consumer.getConnection();
- channel = openChannel(conn);
- // Register the channel to the tag
- start();
+ try {
+ stop();
Review comment:
Yeah that sounds okay lets go with this - its better than whats before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
