[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1888: Test Geocoder with Google maps mock API if GOOGLE_GEOCODER_API_KEY is…

[GitBox]

jamesnetherton commented on a change in pull request #1888:
URL: https://github.com/apache/camel-quarkus/pull/1888#discussion_r501511025



##########
File path: 
extensions/geocoder/deployment/src/main/java/org/apache/camel/quarkus/component/geocoder/deployment/GeocoderProcessor.java
##########
@@ -50,6 +50,7 @@ ExtensionSslNativeSupportBuildItem activateSslNativeSupport() 
{
         items.add(new ReflectiveClassBuildItem(false, true, 
"com.google.maps.model.Bounds"));
         items.add(new ReflectiveClassBuildItem(false, true, 
"com.google.maps.model.LatLng"));
         items.add(new ReflectiveClassBuildItem(false, true, 
"com.google.maps.model.LocationType"));
+        items.add(new ReflectiveClassBuildItem(false, true, 
"com.google.maps.GeoApiContext$Builder"));

Review comment:
       This is only needed for for the reflection hack in the test, right? I 
guess it is not necessary for users normal runtime operation?
   
   If so, we can use a configuration property in the test:
   
   ```
   
quarkus.camel.native.reflection.include-patterns=com.google.maps.GeoApiContext$Builder
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org