oscerd commented on a change in pull request #4343:
URL: https://github.com/apache/camel/pull/4343#discussion_r498509662
##########
File path: parent/pom.xml
##########
@@ -205,7 +205,7 @@
<geronimo-ws-metadata-spec-version>1.1.3</geronimo-ws-metadata-spec-version>
<gmetric4j-version>1.0.10</gmetric4j-version>
<google-guava-version>19.0</google-guava-version>
- <google-pubsub-guava-version>28.2-jre</google-pubsub-guava-version>
+ <google-pubsub-guava-version>29.0-jre</google-pubsub-guava-version>
Review comment:
I think this require a check on the karaf feature if needed
##########
File path: components/camel-google-pubsub/pom.xml
##########
@@ -47,83 +47,7 @@
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsub</artifactId>
<version>${google-cloud-pubsub-version}</version>
- <exclusions>
Review comment:
Are you sure about removing the exclusions?
##########
File path: parent/pom.xml
##########
@@ -215,7 +215,7 @@
<google-api-services-mail-version>v1-rev81-1.22.0</google-api-services-mail-version>
<google-api-services-bigquery-version>v2-rev352-1.22.0</google-api-services-bigquery-version>
<google-api-services-pubsub-version>v1-rev12-1.22.0</google-api-services-pubsub-version>
- <google-cloud-pubsub-version>1.102.0</google-cloud-pubsub-version>
+ <google-cloud-pubsub-version>1.108.1</google-cloud-pubsub-version>
Review comment:
I think that's the reason for removing the exclusions, but we need to
double check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
