lburgazzoli commented on a change in pull request #4307:
URL: https://github.com/apache/camel/pull/4307#discussion_r495728938
##########
File path:
core/camel-health/src/main/java/org/apache/camel/impl/health/RouteHealthCheck.java
##########
@@ -54,7 +54,8 @@ protected void doCall(HealthCheckResultBuilder builder,
Map<String, Object> opti
if (route.getRouteController() != null || route.isAutoStartup()) {
if (status.isStarted()) {
builder.up();
- } else if (status.isStopped()) {
+ }
+ if (status.isStopped()) {
Review comment:
I don't think it effectively changes the result in this case but an if
else makes it clear that it is either started or stopped whereas a list of is
could be confusing like can the status be `started` and `stopped` at the same
time ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
