jamesnetherton commented on a change in pull request #1828:
URL: https://github.com/apache/camel-quarkus/pull/1828#discussion_r494268390
##########
File path:
extensions/stringtemplate/deployment/src/main/java/org/apache/camel/quarkus/component/stringtemplate/deployment/StringtemplateProcessor.java
##########
@@ -17,30 +17,23 @@
package org.apache.camel.quarkus.component.stringtemplate.deployment;
import io.quarkus.deployment.annotations.BuildStep;
-import io.quarkus.deployment.annotations.ExecutionTime;
-import io.quarkus.deployment.annotations.Record;
import io.quarkus.deployment.builditem.FeatureBuildItem;
-import io.quarkus.deployment.pkg.steps.NativeBuild;
-import org.apache.camel.quarkus.core.JvmOnlyRecorder;
-import org.jboss.logging.Logger;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import org.apache.camel.support.DefaultExchange;
class StringtemplateProcessor {
- private static final Logger LOG =
Logger.getLogger(StringtemplateProcessor.class);
private static final String FEATURE = "camel-stringtemplate";
@BuildStep
FeatureBuildItem feature() {
return new FeatureBuildItem(FEATURE);
}
- /**
- * Remove this once this extension starts supporting the native mode.
- */
- @BuildStep(onlyIf = NativeBuild.class)
- @Record(value = ExecutionTime.RUNTIME_INIT)
- void warnJvmInNative(JvmOnlyRecorder recorder) {
- JvmOnlyRecorder.warnJvmInNative(LOG, FEATURE); // warn at build time
- recorder.warnJvmInNative(FEATURE); // warn at runtime
+ @BuildStep
+ ReflectiveClassBuildItem registerForReflectionWithMethods() {
+ return new ReflectiveClassBuildItem(true, false,
+ //required for values in properties
+ DefaultExchange.class.getName());
Review comment:
Maybe we should not do this. See my comments in
https://github.com/apache/camel-quarkus/issues/1807.
##########
File path:
extensions/stringtemplate/deployment/src/main/java/org/apache/camel/quarkus/component/stringtemplate/deployment/StringtemplateProcessor.java
##########
@@ -17,30 +17,23 @@
package org.apache.camel.quarkus.component.stringtemplate.deployment;
import io.quarkus.deployment.annotations.BuildStep;
-import io.quarkus.deployment.annotations.ExecutionTime;
-import io.quarkus.deployment.annotations.Record;
import io.quarkus.deployment.builditem.FeatureBuildItem;
-import io.quarkus.deployment.pkg.steps.NativeBuild;
-import org.apache.camel.quarkus.core.JvmOnlyRecorder;
-import org.jboss.logging.Logger;
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
+import org.apache.camel.support.DefaultExchange;
class StringtemplateProcessor {
- private static final Logger LOG =
Logger.getLogger(StringtemplateProcessor.class);
private static final String FEATURE = "camel-stringtemplate";
@BuildStep
FeatureBuildItem feature() {
return new FeatureBuildItem(FEATURE);
}
- /**
- * Remove this once this extension starts supporting the native mode.
- */
- @BuildStep(onlyIf = NativeBuild.class)
- @Record(value = ExecutionTime.RUNTIME_INIT)
- void warnJvmInNative(JvmOnlyRecorder recorder) {
- JvmOnlyRecorder.warnJvmInNative(LOG, FEATURE); // warn at build time
- recorder.warnJvmInNative(FEATURE); // warn at runtime
+ @BuildStep
+ ReflectiveClassBuildItem registerForReflectionWithMethods() {
+ return new ReflectiveClassBuildItem(true, false,
+ //required for values in properties
+ DefaultExchange.class.getName());
Review comment:
Fine with me :+1:
##########
File path:
integration-tests/stringtemplate/src/test/java/org/apache/camel/quarkus/component/stringtemplate/it/StringtemplateIT.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.stringtemplate.it;
+
+import java.util.Collections;
+
+import io.quarkus.test.junit.NativeImageTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+import org.junit.jupiter.api.Test;
+
+import static org.hamcrest.CoreMatchers.containsString;
+
+@NativeImageTest
+class StringtemplateIT extends StringtemplateTest {
+
+ @Test
+ public void testDisabledContextMapAll() {
+ //allowContextMapAll has to be disabled in native mode
+ RestAssured.given()
Review comment:
We should agree on whether
[this](https://github.com/apache/camel-quarkus/blob/bd845d3959984d575441d3e79cd9a58095b6aa34/extensions/stringtemplate/runtime/src/main/java/org/apache/camel/quarkus/component/stringtemplate/StringtemplateEndpointSubstitute.java)
is the right thing to do.
Originally, I saw the 'fix' to #1807 as purely a documentation exercise.
Where we just state for each affected extension that `contextMapAll` will not
work in native mode.
Potentially forcing `contextMapAll` to `false` is a bit confusing because
you would run into problems at runtime. Where as without it, the native build
would fail, so it's sort like a 'fail fast'.
##########
File path:
integration-tests/stringtemplate/src/test/java/org/apache/camel/quarkus/component/stringtemplate/it/StringtemplateIT.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.stringtemplate.it;
+
+import java.util.Collections;
+
+import io.quarkus.test.junit.NativeImageTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+import org.junit.jupiter.api.Test;
+
+import static org.hamcrest.CoreMatchers.containsString;
+
+@NativeImageTest
+class StringtemplateIT extends StringtemplateTest {
+
+ @Test
+ public void testDisabledContextMapAll() {
+ //allowContextMapAll has to be disabled in native mode
+ RestAssured.given()
Review comment:
We should agree on whether
[this](https://github.com/apache/camel-quarkus/blob/bd845d3959984d575441d3e79cd9a58095b6aa34/extensions/stringtemplate/runtime/src/main/java/org/apache/camel/quarkus/component/stringtemplate/StringtemplateEndpointSubstitute.java)
is the right thing to do.
Originally, I saw the 'fix' to #1807 as purely a documentation exercise.
Where we just state for each affected extension that `contextMapAll` = `true`
will not work in native mode.
Potentially forcing `contextMapAll` to `false` is a bit confusing because
you would run into problems at runtime. Where as without it, the native build
would fail, so it's sort like a 'fail fast'.
##########
File path:
integration-tests/stringtemplate/src/test/java/org/apache/camel/quarkus/component/stringtemplate/it/StringtemplateIT.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.stringtemplate.it;
+
+import java.util.Collections;
+
+import io.quarkus.test.junit.NativeImageTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+import org.junit.jupiter.api.Test;
+
+import static org.hamcrest.CoreMatchers.containsString;
+
+@NativeImageTest
+class StringtemplateIT extends StringtemplateTest {
+
+ @Test
+ public void testDisabledContextMapAll() {
+ //allowContextMapAll has to be disabled in native mode
+ RestAssured.given()
Review comment:
IMO, yes. @ppalaga WDYT?
##########
File path:
integration-tests/stringtemplate/src/test/java/org/apache/camel/quarkus/component/stringtemplate/it/StringtemplateIT.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.stringtemplate.it;
+
+import java.util.Collections;
+
+import io.quarkus.test.junit.NativeImageTest;
+import io.restassured.RestAssured;
+import io.restassured.http.ContentType;
+import org.junit.jupiter.api.Test;
+
+import static org.hamcrest.CoreMatchers.containsString;
+
+@NativeImageTest
+class StringtemplateIT extends StringtemplateTest {
+
+ @Test
+ public void testDisabledContextMapAll() {
+ //allowContextMapAll has to be disabled in native mode
+ RestAssured.given()
Review comment:
Sounds ok to me. Maybe tweak `some expression` to `some expressions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
