ppalaga commented on pull request #1777:
URL: https://github.com/apache/camel-quarkus/pull/1777#issuecomment-691879930


   Thanks @djencks , more inline
   
   > I made a PR against your branch, 
[ppalaga#5](https://github.com/ppalaga/camel-quarkus/pull/5) I added a 
capability to the indexer extension to repeat a “template” block for each 
selected page, and wondered if it would be useful here. 
   
   Here a screenshot for the others to get an idea what it looks like: 
   
   
![image](https://user-images.githubusercontent.com/1826249/93056160-54ede880-f66c-11ea-8509-973152838db5.png)
   
   It is an interesting experiment, but I must say, I like the existing table 
layout more. It takes less space and it is easier to scan visually. What do 
others think?
   
   > I don’t understand how the styling for the status in the table is supposed 
to work…. I don’t see anything visibly different from it. Is there a css update 
pending somewhere? 
   
   No, I do not think there was supposed to be any special styling of the 
status in the table, at least not from me.
   
   Unless somebody wants to veto, I'd extract the changes related to the 
extensions table from @djencks PR 
https://github.com/ppalaga/camel-quarkus/pull/5 and add them to this PR. The 
[extensions 
table](https://camel.apache.org/camel-quarkus/latest/reference/index.html) will 
thus look much like today, but will be powered by 
`@djencks/asciidoctor-antora-indexer` AsciiDoc extension.
   I'll possibly add my work to display separate since versions for JVM and 
native on top of that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to