yashlimbad commented on code in PR #4840:
URL: https://github.com/apache/calcite/pull/4840#discussion_r3085034756
##########
core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java:
##########
@@ -198,14 +202,42 @@ protected void perform(RelOptRuleCall call, @Nullable
Filter filter,
return;
}
+ // Collect the correlation variables (introduced via sub-queries)
referenced
+ // by each bucket of predicates after classifyFilters has decided where
every
+ // conjunct lives. The buckets are needed to (a) plumb variablesSet onto
the
+ // newly-created child Filters and (b) recompute the join's own
variablesSet
+ // without dropping ids that the surviving join condition still references.
+ final Set<CorrelationId> leftVariablesSet = new LinkedHashSet<>();
Review Comment:
but if we revert this, then child filters and join will be created without
`variableSet` right? if not subquery, any normal predicate can also have
correlated variables; and join's copy method can be useful for future purpose
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
