utafrali commented on PR #4878: URL: https://github.com/apache/calcite/pull/4878#issuecomment-4229715900
> > The fix is correct: returning `(input, null)` when a `Sort` is detected in the input chain prevents the rule from incorrectly collapsing UNION branches that have LIMIT/OFFSET semantics. The helper method is clean and the traversal logic handles arbitrary nesting of Project/Filter above a Sort. Two minor gaps: the method name omits Filter from its description, and there is no test for `UNION ALL` with LIMIT. > > > > @utafrali I'm curious how you managed to review this PR in less than 5 minutes. I was already following this case closely, so I had the full context in mind. The changes were straightforward, so the review didn’t take long. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
