xiedeyantu commented on code in PR #4868:
URL: https://github.com/apache/calcite/pull/4868#discussion_r3067978873
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTable.java:
##########
@@ -69,16 +73,13 @@ public class ArrowTable extends AbstractTable
private final @Nullable RelProtoDataType protoRowType;
/** Arrow schema. (In Calcite terminology, more like a row type than a
Schema.) */
private final Schema schema;
- private final ArrowFileReader arrowFileReader;
+ private final File arrowFile;
- ArrowTable(@Nullable RelProtoDataType protoRowType, ArrowFileReader
arrowFileReader) {
- try {
- this.schema = arrowFileReader.getVectorSchemaRoot().getSchema();
- } catch (IOException e) {
- throw Util.toUnchecked(e);
- }
+ ArrowTable(@Nullable RelProtoDataType protoRowType, File arrowFile,
Review Comment:
Could you add some comments for this ArrowTable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
