snuyanzin commented on PR #4874:
URL: https://github.com/apache/calcite/pull/4874#issuecomment-4229327052

   mostly LGTM
   the question I have is whether it makes sense to consider test cases with 
ordinals and aliases
   like `SqlConformance#isGroupByAlias` and `SqlConformance#isGroupByOrdinal`, 
same for `ORDER BY`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to