xuzifu666 commented on code in PR #4870:
URL: https://github.com/apache/calcite/pull/4870#discussion_r3045433812


##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/PredicateAnalyzer.java:
##########
@@ -406,6 +414,8 @@ private QueryExpression binary(RexCall call) {
       case SEARCH:
         if (isSearchWithComplementedPoints(call)) {
           return QueryExpression.create(pair.getKey()).notIn(pair.getValue());
+        } else if (isSearchWithRange(call)) {
+          return QueryExpression.create(pair.getKey()).range(pair.getValue());

Review Comment:
   Make sense,done.



##########
core/src/main/java/org/apache/calcite/util/Bug.java:
##########
@@ -169,7 +169,7 @@ public abstract class Bug {
    * <a 
href="https://issues.apache.org/jira/browse/CALCITE-4645";>[CALCITE-4645]
    * In Elasticsearch adapter, a range predicate should be translated to a 
range query</a> is
    * fixed. */
-  public static final boolean CALCITE_4645_FIXED = false;
+  public static final boolean CALCITE_4645_FIXED = true;

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to