silundong commented on code in PR #4840:
URL: https://github.com/apache/calcite/pull/4840#discussion_r3043675304
##########
core/src/main/java/org/apache/calcite/plan/RelOptUtil.java:
##########
@@ -4752,6 +4759,17 @@ public ImmutableBitSet build() {
}
return super.visitCall(call);
}
+
+ @Override public Void visitSubQuery(RexSubQuery subQuery) {
Review Comment:
If I understand correctly, your changes to `InputFinder` are intended to
support the call within `RelOptUtil.classifyFilters`, and in that method the
argument passed to `InputFinder.analyze` is a `RexNode` (i.e., the join
condition), not the join itself. The `visitSubQuery` method you added in
`InputFinder` uses `RelOptUtil.getVariablesUsed(subQuery.rel)`, so in practice
the argument passed to `RelOptUtil.getVariablesUsed` is
`LogicalFilter(condition=[AND(=($0, $cor0.EMPNO), =($0, $cor1.EMPNO))])`, and
it will return cor0 and cor1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
