caicancai commented on code in PR #4865:
URL: https://github.com/apache/calcite/pull/4865#discussion_r3037129475


##########
core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java:
##########
@@ -533,6 +535,8 @@ public TrimResult trimFields(
       Project project,
       ImmutableBitSet fieldsUsed,
       Set<RelDataTypeField> extraFields) {
+    checkArgument(project.getVariablesSet().size() <= 1,

Review Comment:
   Perhaps including the actual size in the error message would make 
troubleshooting easier.



##########
core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java:
##########
@@ -533,6 +535,8 @@ public TrimResult trimFields(
       Project project,
       ImmutableBitSet fieldsUsed,
       Set<RelDataTypeField> extraFields) {
+    checkArgument(project.getVariablesSet().size() <= 1,

Review Comment:
   I feel that making a judgment at the beginning is not a good choice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to