tmater commented on PR #4844: URL: https://github.com/apache/calcite/pull/4844#issuecomment-4169739039
> Is the behavior with `::` needing parenthesis a new feature, or was this already present previously? @mihaibudiu , good catch! The parenthesis requirement itself is not new, on `main`, `v::varchar[1]` already means "cast to `VARCHAR[1]`" (bracket binds to the type), so parentheses were always needed to subscript the cast result. However, you're right that something was off: the bracket refactor broke parsing `v::varchar[1]` entirely, because InfixCast was implicitly relying on `Expression2()`'s loop to consume postfixes. This commit fixes that by adding an explicit `AddRegularPostfixes(list)` call after `DataType()` in `InfixCast`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
