popduke commented on code in PR #224:
URL: https://github.com/apache/bifromq/pull/224#discussion_r2744306606
##########
release/docker-build.sh:
##########
@@ -74,17 +78,41 @@ fi
context_dir="$artifact_dir"
tag="${tag_override:-apache-bifromq:${version}}"
-if [[ -z "$target_arch" ]]; then
- machine=$(uname -m)
- case "$machine" in
- x86_64|amd64) target_arch="amd64" ;;
- aarch64|arm64|arm64e) target_arch="arm64" ;;
- *) echo "Error: unsupported machine architecture: ${machine}. Set
TARGETARCH explicitly." >&2; exit 1 ;;
- esac
+if [[ -z "$push_image" ]]; then
Review Comment:
DO NOT do docker push in script, just enable cross-build in script is
sufficient. The PUSH action MUST be triggered by docker-publish workflow, since
the required secrets are configured in repo setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
