Gujiawei-Edinburgh commented on code in PR #189:
URL: https://github.com/apache/bifromq/pull/189#discussion_r2542242824
##########
base-kv/base-kv-store-server/src/main/java/org/apache/bifromq/basekv/store/range/KVRangeDumpSession.java:
##########
@@ -301,9 +303,12 @@ private void nextSaveRequest() {
"Dump snapshot completed: sessionId={}, follower={},
totalEntries={}, totalBytes={}, cost={}ms",
sessionId, receiverStoreId, totalEntries, totalBytes,
TimeUnit.NANOSECONDS.toMillis(now - startDumpTS));
- } else {
- log.info("Dump snapshot data: sessionId={}, follower={},
entries={}, bytes={}",
- sessionId, receiverStoreId, reqBuilder.getKvCount(),
dumpBytes);
+ } else if (now - lastProgressLogTS >= PROGRESS_LOG_INTERVAL_NANOS)
{
Review Comment:
It seems does nothing. Is it used for trouble shooting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
