[
https://issues.apache.org/jira/browse/BEAM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768525#comment-15768525
]
ASF GitHub Bot commented on BEAM-469:
-------------------------------------
GitHub user dhalperi opened a pull request:
https://github.com/apache/incubator-beam/pull/1680
[BEAM-XXX] Make KVCoder more efficient by removing unnecessary nesting
See [BEAM-469] for more information about why this is
correct.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/incubator-beam
efficient-nested-coders
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1680
----
commit 621e8250c9535d773c4f4440a34ea0833912b51f
Author: Dan Halperin <[email protected]>
Date: 2016-12-21T23:37:49Z
[BEAM-XXX] Make KVCoder more efficient by removing unnecessary nesting
See [BEAM-469] for more information about why this is
correct.
----
> NullableCoder optimized encoding via passthrough context
> --------------------------------------------------------
>
> Key: BEAM-469
> URL: https://issues.apache.org/jira/browse/BEAM-469
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Thomas Groh
> Priority: Trivial
> Labels: backward-incompatible
> Fix For: 0.3.0-incubating
>
>
> NullableCoder should encode using the context given and not always use the
> nested context. For coders which can efficiently encode in the outer context
> such as StringUtf8Coder or ByteArrayCoder, we are forcing them to prefix
> themselves with their length.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
