This is an automated email from the ASF dual-hosted git repository. pinal pushed a commit to branch atlas-2.5 in repository https://gitbox.apache.org/repos/asf/atlas.git
commit 3222ff38adaf2ffaf29d3fa57c20dbd9f34532ed Author: sheetalshah1007 <sheetal.s...@freestoneinfotech.com> AuthorDate: Mon Mar 24 16:58:34 2025 +0530 ATLAS-4995: corrected checkstyle errors in the missing glossaries patch - commit 92174bbd96bf61228a39b22a3c2b7a16b58cf95c (#311) Co-authored-by: Sheetal Shah <sheetal.s...@cloudera.com> (cherry picked from commit 71ecba206dd3110be5cb990e0e21f9c873a547b9) --- .../src/main/java/org/apache/atlas/glossary/GlossaryService.java | 3 ++- .../src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java b/repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java index c48d2490d..4d3413ce6 100644 --- a/repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java +++ b/repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java @@ -1256,7 +1256,8 @@ public class GlossaryService { PaginationHelper(Collection<T> items) { this.items = new ArrayList<>(items); this.maxSize = items.size(); - pageStart = pageEnd = 0; + pageStart = 0; + pageEnd = 0; } List<T> getPaginatedList() { diff --git a/repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java b/repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java index bee4e44ae..fd92a60be 100644 --- a/repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java +++ b/repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java @@ -1302,7 +1302,6 @@ public class GlossaryServiceTest { @DataProvider(name = "getAllGlossaryForPaginationDataProvider") public Object[][] getAllGlossaryForPaginationDataProvider() { - List<String> listAllGuids = Arrays.asList("guid-1", "guid-2", "guid-3", "guid-4", "guid-5", "guid-6", "guid-7", "guid-8", "guid-9", "guid-10"); @@ -1324,14 +1323,12 @@ public class GlossaryServiceTest { @Test(dataProvider = "getAllGlossaryForPaginationDataProvider") void testGetGlossaries_WithPaginationHandlingSkippedGlossaries(int limit, int offset, SortOrder sortOrder, int expectedSize, List<String> allGlossaryGuids, List<String> guidsToSkip, int expectedPageCount) throws Exception { - mockedEntityStore = mock(AtlasEntityStore.class); when(mockedDataAccess.getAtlasEntityStore()).thenReturn(mockedEntityStore); List<String> finalGuidsToSkip = (guidsToSkip == null) ? Collections.emptyList() : guidsToSkip; try (MockedStatic<AtlasGraphUtilsV2> mockedGraphUtilsClass = Mockito.mockStatic(AtlasGraphUtilsV2.class)) { - // Mocking the retrieval of glossary GUIDs from the system mockedGraphUtilsClass.when(() -> AtlasGraphUtilsV2.findEntityGUIDsByType(anyString(), any())) .thenReturn(allGlossaryGuids);