This is an automated email from the ASF dual-hosted git repository. madhan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/atlas.git
The following commit(s) were added to refs/heads/master by this push: new 88a23cb3a ATLAS-4962: atlas-example modules: update for code readability improvements (#290) 88a23cb3a is described below commit 88a23cb3ad20f6ebd052a1cf2884ab2f0e8d8361 Author: sheetalshah1007 <sheetal.s...@freestoneinfotech.com> AuthorDate: Sat Feb 15 08:00:38 2025 +0530 ATLAS-4962: atlas-example modules: update for code readability improvements (#290) --- atlas-examples/pom.xml | 5 + .../atlas/examples/sampleapp/DiscoveryExample.java | 2 +- .../atlas/examples/sampleapp/EntityExample.java | 68 +++++++---- .../atlas/examples/sampleapp/GlossaryExample.java | 6 +- .../atlas/examples/sampleapp/LineageExample.java | 4 +- .../apache/atlas/examples/sampleapp/SampleApp.java | 14 +-- .../examples/sampleapp/SampleAppConstants.java | 19 +-- .../atlas/examples/sampleapp/TypeDefExample.java | 136 +++++++++++++-------- 8 files changed, 160 insertions(+), 94 deletions(-) diff --git a/atlas-examples/pom.xml b/atlas-examples/pom.xml index 203ac127d..6eb1d235e 100644 --- a/atlas-examples/pom.xml +++ b/atlas-examples/pom.xml @@ -31,4 +31,9 @@ <modules> <module>sample-app</module> </modules> + + <properties> + <checkstyle.failOnViolation>true</checkstyle.failOnViolation> + <checkstyle.skip>false</checkstyle.skip> + </properties> </project> diff --git a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java index d309c9ed4..7a8472edf 100644 --- a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java +++ b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java @@ -26,7 +26,7 @@ import org.apache.atlas.model.instance.AtlasEntityHeader; import java.util.List; public class DiscoveryExample { - private static final String[] DSL_QUERIES = new String[] { "from DataSet", "from Process" }; + private static final String[] DSL_QUERIES = new String[] {"from DataSet", "from Process"}; private final AtlasClientV2 client; diff --git a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java index 3d9d4845b..286e1a197 100644 --- a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java +++ b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java @@ -33,7 +33,33 @@ import java.util.Arrays; import java.util.List; import static java.util.Arrays.asList; -import static org.apache.atlas.examples.sampleapp.SampleAppConstants.*; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_COLUMNS; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_COMMENT; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_COMPRESSED; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_CREATE_TIME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_DATA_TYPE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_DB; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_END_TIME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_INPUTS; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_LAST_ACCESS_TIME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_LEVEL; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_LOCATION_URI; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_OPERATION_TYPE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_OUTPUTS; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_OWNER; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_QUERY_GRAPH; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_QUERY_ID; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_QUERY_PLAN; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_QUERY_TEXT; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_SERDE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_SERDE1; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_SERDE2; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_START_TIME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_TABLE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_TABLE_TYPE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_USERNAME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.STRUCT_TYPE_SERDE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.TABLE_DATABASE_TYPE; import static org.apache.atlas.type.AtlasTypeUtil.toAtlasRelatedObjectId; import static org.apache.atlas.type.AtlasTypeUtil.toAtlasRelatedObjectIds; @@ -115,11 +141,25 @@ public class EntityExample { } } + protected AtlasEntity createHiveDBInstance(String dbName) { + AtlasEntity entity = new AtlasEntity(SampleAppConstants.DATABASE_TYPE); + + entity.setAttribute(ATTR_NAME, dbName); + entity.setAttribute(ATTR_DESCRIPTION, "employee database"); + entity.setAttribute(METADATA_NAMESPACE_SUFFIX, "employeeCluster"); + entity.setAttribute(REFERENCEABLE_ATTRIBUTE_NAME, dbName + METADATA_NAMESPACE_SUFFIX); + entity.setAttribute(ATTR_OWNER, "user"); + entity.setAttribute(ATTR_LOCATION_URI, "/tmp"); + entity.setAttribute(ATTR_CREATE_TIME, 1000); + + return entity; + } + private AtlasEntity createTableEntity(String tableName) throws Exception { return createHiveTable(dbEntity, tableName, MANAGED_TABLE, Arrays.asList(createColumn(COLUMN_TIME_ID, "int", "time id"), - createColumn(COLUMN_CUSTOMER_ID, "int", "customer id", SampleAppConstants.PII_TAG), - createColumn(COLUMN_COMPANY_ID, "double", "company id", SampleAppConstants.FINANCE_TAG)), + createColumn(COLUMN_CUSTOMER_ID, "int", "customer id", SampleAppConstants.PII_TAG), + createColumn(COLUMN_COMPANY_ID, "double", "company id", SampleAppConstants.FINANCE_TAG)), SampleAppConstants.METRIC_TAG); } @@ -131,8 +171,7 @@ public class EntityExample { } private AtlasEntityHeader createProcess(String name, String description, String user, List<AtlasEntity> inputs, List<AtlasEntity> outputs, - String queryText, String queryPlan, String queryId, String queryGraph, String... classificationNames) throws Exception { - + String queryText, String queryPlan, String queryId, String queryGraph, String... classificationNames) throws Exception { AtlasEntity entity = new AtlasEntity(SampleAppConstants.PROCESS_TYPE); entity.setAttribute(ATTR_NAME, name); @@ -212,24 +251,10 @@ public class EntityExample { return hiveDBInstance; } - protected AtlasEntity createHiveDBInstance(String dbName) { - AtlasEntity entity = new AtlasEntity(SampleAppConstants.DATABASE_TYPE); - - entity.setAttribute(ATTR_NAME, dbName); - entity.setAttribute(ATTR_DESCRIPTION, "employee database"); - entity.setAttribute(METADATA_NAMESPACE_SUFFIX, "employeeCluster"); - entity.setAttribute(REFERENCEABLE_ATTRIBUTE_NAME, dbName + METADATA_NAMESPACE_SUFFIX); - entity.setAttribute(ATTR_OWNER, "user"); - entity.setAttribute(ATTR_LOCATION_URI, "/tmp"); - entity.setAttribute(ATTR_CREATE_TIME, 1000); - - return entity; - } - private AtlasEntity createHiveTable(AtlasEntity database, String tableName, String tableType, List<AtlasEntity> columns, String... classificationNames) throws Exception { AtlasEntityWithExtInfo entityWithExtInfo = new AtlasEntityWithExtInfo(); + AtlasEntity hiveTableInstance = createHiveTable(database, tableName, tableType, classificationNames); - AtlasEntity hiveTableInstance = createHiveTable(database, tableName, tableType, classificationNames); entityWithExtInfo.setEntity(hiveTableInstance); hiveTableInstance.setRelationshipAttribute(ATTR_COLUMNS, toAtlasRelatedObjectIds(columns)); @@ -268,10 +293,11 @@ public class EntityExample { table.setAttribute(ATTR_SERDE1, serde1); AtlasStruct serde2 = new AtlasStruct(STRUCT_TYPE_SERDE); + serde2.setAttribute(ATTR_NAME, "serde2"); serde2.setAttribute(ATTR_SERDE, "serde2"); table.setAttribute(ATTR_SERDE2, serde2); return table; } -} \ No newline at end of file +} diff --git a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java index 7d5690ce8..6d3ea24ac 100644 --- a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java +++ b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java @@ -49,7 +49,9 @@ public class GlossaryExample { public void getGlossaryDetail() throws Exception { AtlasGlossaryExtInfo extInfo = client.getGlossaryExtInfo(empGlossary.getGuid()); - assert (extInfo != null); + if (extInfo == null) { + throw new IllegalStateException("Glossary extended info is null for GUID: " + empGlossary.getGuid()); + } SampleApp.log("Glossary extended info: " + extInfo.getGuid() + "; name: " + extInfo.getName() + "; language: " + extInfo.getLanguage()); } @@ -82,7 +84,7 @@ public class GlossaryExample { return; } - AtlasGlossaryHeader glossary = new AtlasGlossaryHeader(); + AtlasGlossaryHeader glossary = new AtlasGlossaryHeader(); AtlasGlossaryCategory category = new AtlasGlossaryCategory(); glossary.setGlossaryGuid(empGlossary.getGuid()); diff --git a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java index aba3b812d..ec654e4f7 100644 --- a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java +++ b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java @@ -42,7 +42,7 @@ public class LineageExample { AtlasEntityHeader toEntity = guidEntityMap.get(relation.getToEntityId()); SampleApp.log(fromEntity.getDisplayText() + "(" + fromEntity.getTypeName() + ") -> " + - toEntity.getDisplayText() + "(" + toEntity.getTypeName() + ")"); + toEntity.getDisplayText() + "(" + toEntity.getTypeName() + ")"); } } -} \ No newline at end of file +} diff --git a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java index f663de16b..9fbd05a60 100644 --- a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java +++ b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java @@ -101,7 +101,7 @@ public class SampleApp { discoveryExample.testSearch(); discoveryExample.quickSearch(entity.getTypeName()); - discoveryExample.basicSearch(entity.getTypeName(), SampleAppConstants.METRIC_TAG, (String)entity.getAttribute(SampleAppConstants.ATTR_NAME)); + discoveryExample.basicSearch(entity.getTypeName(), SampleAppConstants.METRIC_TAG, (String) entity.getAttribute(SampleAppConstants.ATTR_NAME)); } private void glossaryExample() throws Exception { @@ -116,11 +116,11 @@ public class SampleApp { private static String[] getUserInput() { try { - String username = System.console().readLine("Enter username: "); - char[] pwChar = System.console().readPassword("Enter password: "); - String password = (pwChar != null) ? new String(pwChar) : ""; + String username = System.console().readLine("Enter username: "); + char[] pwChar = System.console().readPassword("Enter password: "); + String password = (pwChar != null) ? new String(pwChar) : ""; - return new String[] { username, password }; + return new String[] {username, password}; } catch (Exception e) { System.out.print("Error while reading user input"); System.exit(1); @@ -133,7 +133,7 @@ public class SampleApp { try { String atlasServerUrl = System.console().readLine("Enter Atlas server URL: "); - return new String[] { atlasServerUrl }; + return new String[] {atlasServerUrl}; } catch (Exception e) { System.out.print("Error while reading user input"); System.exit(1); @@ -141,4 +141,4 @@ public class SampleApp { return null; // will not reach here } -} \ No newline at end of file +} diff --git a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java index 4b7b44dc9..f6d117d22 100644 --- a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java +++ b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java @@ -56,15 +56,15 @@ public final class SampleAppConstants { public static final String ENTITY_TYPE_DATASET = "DataSet"; public static final String ENTITY_TYPE_PROCESS = "Process"; - public static final String PII_TAG = "SAMPLE_PII"; - public static final String FINANCE_TAG = "SAMPLE_FINANCE"; - public static final String CLASSIFIED_TAG = "SAMPLE_CLASSIFIED"; - public static final String METRIC_TAG = "SAMPLE_METRIC"; + public static final String PII_TAG = "SAMPLE_PII"; + public static final String FINANCE_TAG = "SAMPLE_FINANCE"; + public static final String CLASSIFIED_TAG = "SAMPLE_CLASSIFIED"; + public static final String METRIC_TAG = "SAMPLE_METRIC"; - public static final String DATABASE_TYPE = "sample_db_type"; - public static final String PROCESS_TYPE = "sample_process_type"; - public static final String TABLE_TYPE = "sample_table_type"; - public static final String COLUMN_TYPE = "sample_column_type"; + public static final String DATABASE_TYPE = "sample_db_type"; + public static final String PROCESS_TYPE = "sample_process_type"; + public static final String TABLE_TYPE = "sample_table_type"; + public static final String COLUMN_TYPE = "sample_column_type"; public static final String TABLE_DATABASE_TYPE = "sample_db_tables"; public static final String TABLE_COLUMNS_TYPE = "sample_table_columns"; @@ -72,4 +72,7 @@ public final class SampleAppConstants { public static final String BUSINESS_METADATA_TYPE = "sample_bmWithAllTypes"; public static final String BUSINESS_METADATA_TYPE_MV = "sample_bmWithAllTypesMV"; public static final String STRUCT_TYPE_SERDE = "sample_serdeType"; + + private SampleAppConstants() { + } } diff --git a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java index be89bd1b6..5ccdc3548 100644 --- a/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java +++ b/atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java @@ -33,14 +33,42 @@ import org.apache.atlas.model.typedef.AtlasTypesDef; import org.apache.atlas.type.AtlasTypeUtil; import javax.ws.rs.core.MultivaluedMap; + import java.util.Arrays; import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; -import static org.apache.atlas.examples.sampleapp.SampleAppConstants.*; -import static org.apache.atlas.model.typedef.AtlasBaseTypeDef.*; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_ATTR1; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_ATTR11; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_ATTR18; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_ATTR2; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_ATTR8; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_COMMENT; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_CREATE_TIME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_DATA_TYPE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_END_TIME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_LAST_ACCESS_TIME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_QUERY_GRAPH; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_QUERY_ID; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_QUERY_PLAN; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_QUERY_TEXT; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_RANDOM_TABLE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_SERDE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_SERDE1; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_SERDE2; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_START_TIME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_TABLE_TYPE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_TEMPORARY; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ATTR_USERNAME; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ENTITY_TYPE_DATASET; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ENTITY_TYPE_PROCESS; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.ENUM_TABLE_TYPE; +import static org.apache.atlas.examples.sampleapp.SampleAppConstants.STRUCT_TYPE_SERDE; +import static org.apache.atlas.model.typedef.AtlasBaseTypeDef.ATLAS_TYPE_BOOLEAN; +import static org.apache.atlas.model.typedef.AtlasBaseTypeDef.ATLAS_TYPE_BYTE; +import static org.apache.atlas.model.typedef.AtlasBaseTypeDef.ATLAS_TYPE_STRING; import static org.apache.atlas.model.typedef.AtlasRelationshipDef.RelationshipCategory.AGGREGATION; import static org.apache.atlas.model.typedef.AtlasRelationshipDef.RelationshipCategory.COMPOSITION; import static org.apache.atlas.model.typedef.AtlasStructDef.AtlasAttributeDef.Cardinality.SET; @@ -83,11 +111,11 @@ public class TypeDefExample { List<AtlasRelationshipDef> relationshipDefs = createAtlasRelationshipDef(); AtlasTypesDef typesDef = new AtlasTypesDef(Collections.singletonList(tableTypeDef), - Collections.singletonList(serDeDef), - classificationDefs, - Arrays.asList(databaseDef, tableDef, columnDef, processDef), - relationshipDefs, - businessMetadataDef); + Collections.singletonList(serDeDef), + classificationDefs, + Arrays.asList(databaseDef, tableDef, columnDef, processDef), + relationshipDefs, + businessMetadataDef); this.typesDef = batchCreateTypes(typesDef); } @@ -102,7 +130,9 @@ public class TypeDefExample { AtlasTypesDef typesDef = client.getAllTypeDefs(searchFilter); - assert (!typesDef.isEmpty()); + if (typesDef.isEmpty()) { + throw new IllegalStateException("Type definition is empty for type: " + typeName); + } SampleApp.log("Created type: " + typeName); } @@ -120,55 +150,55 @@ public class TypeDefExample { private AtlasEntityDef createDatabaseDef() { return AtlasTypeUtil.createClassTypeDef(SampleAppConstants.DATABASE_TYPE, - Collections.singleton(ENTITY_TYPE_DATASET), - AtlasTypeUtil.createOptionalAttrDef("locationUri", "string"), - AtlasTypeUtil.createOptionalAttrDef(ATTR_CREATE_TIME, "long"), - new AtlasAttributeDef(ATTR_RANDOM_TABLE, - AtlasBaseTypeDef.getArrayTypeName(SampleAppConstants.TABLE_TYPE), - true, AtlasAttributeDef.Cardinality.SET)); + Collections.singleton(ENTITY_TYPE_DATASET), + AtlasTypeUtil.createOptionalAttrDef("locationUri", "string"), + AtlasTypeUtil.createOptionalAttrDef(ATTR_CREATE_TIME, "long"), + new AtlasAttributeDef(ATTR_RANDOM_TABLE, + AtlasBaseTypeDef.getArrayTypeName(SampleAppConstants.TABLE_TYPE), + true, AtlasAttributeDef.Cardinality.SET)); } private AtlasEntityDef createTableDef() { return AtlasTypeUtil.createClassTypeDef(SampleAppConstants.TABLE_TYPE, - Collections.singleton(ENTITY_TYPE_DATASET), - createOptionalAttrDef(ATTR_CREATE_TIME, "long"), - createOptionalAttrDef(ATTR_LAST_ACCESS_TIME, "date"), - createOptionalAttrDef(ATTR_TEMPORARY, "boolean"), - createOptionalAttrDef(ATTR_TABLE_TYPE, ENUM_TABLE_TYPE), - createOptionalAttrDef(ATTR_SERDE1, STRUCT_TYPE_SERDE), - createOptionalAttrDef(ATTR_SERDE2, STRUCT_TYPE_SERDE)); + Collections.singleton(ENTITY_TYPE_DATASET), + createOptionalAttrDef(ATTR_CREATE_TIME, "long"), + createOptionalAttrDef(ATTR_LAST_ACCESS_TIME, "date"), + createOptionalAttrDef(ATTR_TEMPORARY, "boolean"), + createOptionalAttrDef(ATTR_TABLE_TYPE, ENUM_TABLE_TYPE), + createOptionalAttrDef(ATTR_SERDE1, STRUCT_TYPE_SERDE), + createOptionalAttrDef(ATTR_SERDE2, STRUCT_TYPE_SERDE)); } private AtlasEntityDef createColumnDef() { return AtlasTypeUtil.createClassTypeDef(SampleAppConstants.COLUMN_TYPE, - Collections.singleton(ENTITY_TYPE_DATASET), - AtlasTypeUtil.createOptionalAttrDef(ATTR_DATA_TYPE, "string"), - AtlasTypeUtil.createOptionalAttrDef(ATTR_COMMENT, "string")); + Collections.singleton(ENTITY_TYPE_DATASET), + AtlasTypeUtil.createOptionalAttrDef(ATTR_DATA_TYPE, "string"), + AtlasTypeUtil.createOptionalAttrDef(ATTR_COMMENT, "string")); } private AtlasEntityDef createProcessDef() { return AtlasTypeUtil.createClassTypeDef(SampleAppConstants.PROCESS_TYPE, - Collections.singleton(ENTITY_TYPE_PROCESS), - AtlasTypeUtil.createOptionalAttrDef(ATTR_USERNAME, "string"), - AtlasTypeUtil.createOptionalAttrDef(ATTR_START_TIME, "long"), - AtlasTypeUtil.createOptionalAttrDef(ATTR_END_TIME, "long"), - AtlasTypeUtil.createRequiredAttrDef(ATTR_QUERY_TEXT, "string"), - AtlasTypeUtil.createRequiredAttrDef(ATTR_QUERY_PLAN, "string"), - AtlasTypeUtil.createRequiredAttrDef(ATTR_QUERY_ID, "string"), - AtlasTypeUtil.createRequiredAttrDef(ATTR_QUERY_GRAPH, "string")); + Collections.singleton(ENTITY_TYPE_PROCESS), + AtlasTypeUtil.createOptionalAttrDef(ATTR_USERNAME, "string"), + AtlasTypeUtil.createOptionalAttrDef(ATTR_START_TIME, "long"), + AtlasTypeUtil.createOptionalAttrDef(ATTR_END_TIME, "long"), + AtlasTypeUtil.createRequiredAttrDef(ATTR_QUERY_TEXT, "string"), + AtlasTypeUtil.createRequiredAttrDef(ATTR_QUERY_PLAN, "string"), + AtlasTypeUtil.createRequiredAttrDef(ATTR_QUERY_ID, "string"), + AtlasTypeUtil.createRequiredAttrDef(ATTR_QUERY_GRAPH, "string")); } private AtlasStructDef createSerDeDef() { return AtlasTypeUtil.createStructTypeDef(SampleAppConstants.STRUCT_TYPE_SERDE, - AtlasTypeUtil.createRequiredAttrDef(SampleAppConstants.ATTR_NAME, "string"), - AtlasTypeUtil.createRequiredAttrDef(ATTR_SERDE, "string")); + AtlasTypeUtil.createRequiredAttrDef(SampleAppConstants.ATTR_NAME, "string"), + AtlasTypeUtil.createRequiredAttrDef(ATTR_SERDE, "string")); } private AtlasEnumDef createTableTypeEnumDef() { return new AtlasEnumDef(SampleAppConstants.ENUM_TABLE_TYPE, - SampleAppConstants.ATTR_DESCRIPTION, - Arrays.asList(new AtlasEnumDef.AtlasEnumElementDef("MANAGED", null, 1), - new AtlasEnumDef.AtlasEnumElementDef("EXTERNAL", null, 2))); + SampleAppConstants.ATTR_DESCRIPTION, + Arrays.asList(new AtlasEnumDef.AtlasEnumElementDef("MANAGED", null, 1), + new AtlasEnumDef.AtlasEnumElementDef("EXTERNAL", null, 2))); } private List<AtlasClassificationDef> createClassificationDefs() { @@ -189,31 +219,31 @@ public class TypeDefExample { options.put("applicableEntityTypes", "[\"" + SampleAppConstants.DATABASE_TYPE + "\",\"" + SampleAppConstants.TABLE_TYPE + "\"]"); AtlasBusinessMetadataDef bmWithAllTypes = createBusinessMetadataDef(SampleAppConstants.BUSINESS_METADATA_TYPE, - description, - "1.0", - createOptionalAttrDef(ATTR_ATTR1, ATLAS_TYPE_BOOLEAN, options, description), - createOptionalAttrDef(ATTR_ATTR2, ATLAS_TYPE_BYTE, options, description), - createOptionalAttrDef(ATTR_ATTR8, ATLAS_TYPE_STRING, options, description)); + description, + "1.0", + createOptionalAttrDef(ATTR_ATTR1, ATLAS_TYPE_BOOLEAN, options, description), + createOptionalAttrDef(ATTR_ATTR2, ATLAS_TYPE_BYTE, options, description), + createOptionalAttrDef(ATTR_ATTR8, ATLAS_TYPE_STRING, options, description)); AtlasBusinessMetadataDef bmWithAllTypesMV = createBusinessMetadataDef(SampleAppConstants.BUSINESS_METADATA_TYPE_MV, - description, - "1.0", - createOptionalAttrDef(ATTR_ATTR11, "array<boolean>", options, description), - createOptionalAttrDef(ATTR_ATTR18, "array<string>", options, description)); + description, + "1.0", + createOptionalAttrDef(ATTR_ATTR11, "array<boolean>", options, description), + createOptionalAttrDef(ATTR_ATTR18, "array<string>", options, description)); return Arrays.asList(bmWithAllTypes, bmWithAllTypesMV); } private List<AtlasRelationshipDef> createAtlasRelationshipDef() { AtlasRelationshipDef dbTablesDef = createRelationshipTypeDef(SampleAppConstants.TABLE_DATABASE_TYPE, SampleAppConstants.TABLE_DATABASE_TYPE, - "1.0", AGGREGATION, AtlasRelationshipDef.PropagateTags.NONE, - createRelationshipEndDef(SampleAppConstants.TABLE_TYPE, "db", SINGLE, false), - createRelationshipEndDef(SampleAppConstants.DATABASE_TYPE, "tables", SET, true)); + "1.0", AGGREGATION, AtlasRelationshipDef.PropagateTags.NONE, + createRelationshipEndDef(SampleAppConstants.TABLE_TYPE, "db", SINGLE, false), + createRelationshipEndDef(SampleAppConstants.DATABASE_TYPE, "tables", SET, true)); AtlasRelationshipDef tableColumnsDef = createRelationshipTypeDef(SampleAppConstants.TABLE_COLUMNS_TYPE, SampleAppConstants.TABLE_COLUMNS_TYPE, - "1.0", COMPOSITION, AtlasRelationshipDef.PropagateTags.NONE, - createRelationshipEndDef(SampleAppConstants.TABLE_TYPE, "columns", SET, true), - createRelationshipEndDef(SampleAppConstants.COLUMN_TYPE, "table", SINGLE, false)); + "1.0", COMPOSITION, AtlasRelationshipDef.PropagateTags.NONE, + createRelationshipEndDef(SampleAppConstants.TABLE_TYPE, "columns", SET, true), + createRelationshipEndDef(SampleAppConstants.COLUMN_TYPE, "table", SINGLE, false)); return Arrays.asList(dbTablesDef, tableColumnsDef); } @@ -271,4 +301,4 @@ public class TypeDefExample { return client.createAtlasTypeDefs(typesToCreate); } -} \ No newline at end of file +}