This is an automated email from the ASF dual-hosted git repository. madhan pushed a change to branch atlas-2.5 in repository https://gitbox.apache.org/repos/asf/atlas.git
from e2d36ac9d ATLAS-4980: fix test setup failure in HBaseAtlasHookIT new 4e10950f0 ATLAS-4937: update checkstyle to improve code readability (#269) new 55655786b ATLAS-4957: checkstyle compliance updates - atlas-common module (#272) new 4f3566647 ATLAS-4960: checkstyle compliance updates - atlas-intg module (#273) The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build-tools/src/main/resources/checkstyle.xml | 240 ----- common/pom.xml | 5 + .../main/java/org/apache/atlas/AtlasConstants.java | 16 +- .../annotation/ConditionalOnAtlasProperty.java | 3 +- .../java/org/apache/atlas/annotation/Timed.java | 11 +- .../atlas/groovy/AbstractFunctionExpression.java | 22 +- .../atlas/groovy/AbstractGroovyExpression.java | 15 +- .../apache/atlas/groovy/ArithmeticExpression.java | 46 +- .../org/apache/atlas/groovy/BinaryExpression.java | 21 +- .../org/apache/atlas/groovy/CastExpression.java | 20 +- .../org/apache/atlas/groovy/ClosureExpression.java | 85 +- .../apache/atlas/groovy/ComparisonExpression.java | 51 +- .../atlas/groovy/ComparisonOperatorExpression.java | 8 +- .../org/apache/atlas/groovy/FieldExpression.java | 13 +- .../atlas/groovy/FunctionCallExpression.java | 51 +- .../org/apache/atlas/groovy/GroovyExpression.java | 8 +- .../atlas/groovy/GroovyGenerationContext.java | 20 +- .../apache/atlas/groovy/IdentifierExpression.java | 27 +- .../org/apache/atlas/groovy/LabeledExpression.java | 15 +- .../org/apache/atlas/groovy/ListExpression.java | 18 +- .../org/apache/atlas/groovy/LiteralExpression.java | 99 +- .../org/apache/atlas/groovy/LogicalExpression.java | 38 +- .../org/apache/atlas/groovy/RangeExpression.java | 24 +- .../atlas/groovy/StatementListExpression.java | 31 +- .../atlas/groovy/TernaryOperatorExpression.java | 37 +- .../org/apache/atlas/groovy/TraversalStepType.java | 6 +- .../atlas/groovy/TypeCoersionExpression.java | 18 +- .../atlas/groovy/VariableAssignmentExpression.java | 25 +- .../java/org/apache/atlas/ha/HAConfiguration.java | 154 ++- .../java/org/apache/atlas/pc/StatusReporter.java | 42 +- .../java/org/apache/atlas/pc/WorkItemBuilder.java | 6 +- .../java/org/apache/atlas/pc/WorkItemConsumer.java | 20 +- .../java/org/apache/atlas/pc/WorkItemManager.java | 67 +- .../org/apache/atlas/repository/Constants.java | 105 +- .../java/org/apache/atlas/service/Service.java | 7 +- .../java/org/apache/atlas/service/Services.java | 4 +- .../apache/atlas/utils/AtlasPathExtractorUtil.java | 181 ++-- .../org/apache/atlas/utils/AtlasPerfMetrics.java | 44 +- .../org/apache/atlas/utils/AtlasPerfTracer.java | 28 +- .../atlas/utils/HdfsNameServiceResolver.java | 77 +- .../java/org/apache/atlas/utils/KafkaUtils.java | 277 +++-- .../main/java/org/apache/atlas/utils/LruCache.java | 44 +- .../atlas/utils/OnAtlasPropertyCondition.java | 21 +- .../java/org/apache/atlas/utils/ParamChecker.java | 19 +- .../apache/atlas/utils/PathExtractorContext.java | 8 +- .../org/apache/atlas/utils/PropertiesUtil.java | 100 +- .../java/org/apache/atlas/utils/SHA256Utils.java | 48 +- .../org/apache/atlas/ha/HAConfigurationTest.java | 24 +- .../atlas/utils/AtlasPathExtractorUtilTest.java | 240 ++--- .../atlas/utils/HdfsNameServiceResolverTest.java | 4 +- .../org/apache/atlas/utils/KafkaUtilsTest.java | 209 ++-- .../java/org/apache/atlas/utils/LruCacheTest.java | 71 +- dev-support/AtlasCodeScheme-IntelliJ.xml | 501 +++++++++ .../checkstyle-suppressions.xml | 7 +- dev-support/checkstyle.xml | 272 +++++ intg/pom.xml | 5 + .../org/apache/atlas/ApplicationProperties.java | 200 ++-- .../java/org/apache/atlas/AtlasConfiguration.java | 43 +- .../main/java/org/apache/atlas/AtlasErrorCode.java | 54 +- .../main/java/org/apache/atlas/AtlasException.java | 7 +- .../src/main/java/org/apache/atlas/DeleteType.java | 8 +- intg/src/main/java/org/apache/atlas/SortOrder.java | 6 +- .../atlas/bulkimport/BulkImportResponse.java | 29 +- .../apache/atlas/exception/AtlasBaseException.java | 26 +- .../apache/atlas/model/AtlasBaseModelObject.java | 42 +- .../java/org/apache/atlas/model/Clearable.java | 6 +- .../main/java/org/apache/atlas/model/PList.java | 41 +- .../java/org/apache/atlas/model/SearchFilter.java | 39 +- .../java/org/apache/atlas/model/TimeBoundary.java | 48 +- .../java/org/apache/atlas/model/TypeCategory.java | 4 +- .../apache/atlas/model/annotation/AtlasJSON.java | 6 +- .../apache/atlas/model/audit/AtlasAuditEntry.java | 118 ++- .../atlas/model/audit/AuditReductionCriteria.java | 45 +- .../atlas/model/audit/AuditSearchParameters.java | 67 +- .../atlas/model/audit/EntityAuditEventV2.java | 262 ++--- .../model/discovery/AtlasAggregationEntry.java | 33 +- .../model/discovery/AtlasQuickSearchResult.java | 12 +- .../atlas/model/discovery/AtlasSearchResult.java | 250 +++-- .../discovery/AtlasSearchResultDownloadStatus.java | 29 +- .../model/discovery/AtlasSuggestionsResult.java | 4 +- .../model/discovery/QuickSearchParameters.java | 17 +- .../discovery/RelationshipSearchParameters.java | 21 +- .../atlas/model/discovery/SearchParameters.java | 276 ++--- .../apache/atlas/model/glossary/AtlasGlossary.java | 127 ++- .../model/glossary/AtlasGlossaryBaseObject.java | 43 +- .../model/glossary/AtlasGlossaryCategory.java | 60 +- .../atlas/model/glossary/AtlasGlossaryTerm.java | 184 ++-- .../model/glossary/AtlasGlossaryTermHeader.java | 34 +- .../glossary/enums/AtlasTermAssignmentStatus.java | 5 +- .../enums/AtlasTermRelationshipStatus.java | 5 +- .../glossary/relations/AtlasGlossaryHeader.java | 30 +- .../relations/AtlasRelatedCategoryHeader.java | 39 +- .../glossary/relations/AtlasRelatedTermHeader.java | 63 +- .../relations/AtlasTermAssignmentHeader.java | 89 +- .../relations/AtlasTermCategorizationHeader.java | 39 +- .../atlas/model/impexp/AtlasExportRequest.java | 68 +- .../atlas/model/impexp/AtlasExportResult.java | 81 +- .../atlas/model/impexp/AtlasImportRequest.java | 109 +- .../atlas/model/impexp/AtlasImportResult.java | 41 +- .../org/apache/atlas/model/impexp/AtlasServer.java | 33 +- .../atlas/model/impexp/AttributeTransform.java | 16 +- .../atlas/model/impexp/ExportImportAuditEntry.java | 51 +- .../apache/atlas/model/impexp/MigrationStatus.java | 38 +- .../model/instance/AtlasCheckStateRequest.java | 20 +- .../model/instance/AtlasCheckStateResult.java | 66 +- .../atlas/model/instance/AtlasClassification.java | 87 +- .../apache/atlas/model/instance/AtlasEntity.java | 286 ++--- .../atlas/model/instance/AtlasEntityHeader.java | 68 +- .../atlas/model/instance/AtlasEntityHeaders.java | 27 +- .../apache/atlas/model/instance/AtlasObjectId.java | 76 +- .../atlas/model/instance/AtlasRelatedObjectId.java | 126 ++- .../atlas/model/instance/AtlasRelationship.java | 244 +++-- .../model/instance/AtlasRelationshipHeader.java | 61 +- .../apache/atlas/model/instance/AtlasStruct.java | 226 ++-- .../instance/ClassificationAssociateRequest.java | 73 +- .../model/instance/EntityMutationResponse.java | 140 +-- .../atlas/model/instance/EntityMutations.java | 144 +-- .../apache/atlas/model/instance/GuidMapping.java | 37 +- .../apache/atlas/model/legacy/EntityResult.java | 47 +- .../atlas/model/lineage/AtlasLineageInfo.java | 113 +- .../model/lineage/LineageOnDemandConstraints.java | 12 +- .../apache/atlas/model/metrics/AtlasMetrics.java | 14 +- .../model/metrics/AtlasMetricsMapToChart.java | 18 +- .../atlas/model/metrics/AtlasMetricsStat.java | 49 +- .../model/migration/MigrationImportStatus.java | 26 +- .../notification/AtlasNotificationBaseMessage.java | 159 ++- .../notification/AtlasNotificationMessage.java | 30 +- .../AtlasNotificationStringMessage.java | 31 +- .../model/notification/EntityNotification.java | 78 +- .../atlas/model/notification/HookNotification.java | 71 +- .../atlas/model/notification/MessageSource.java | 50 +- .../atlas/model/notification/MessageVersion.java | 55 +- .../org/apache/atlas/model/patches/AtlasPatch.java | 84 +- .../atlas/model/profile/AtlasUserProfile.java | 23 +- .../atlas/model/profile/AtlasUserSavedSearch.java | 44 +- .../org/apache/atlas/model/tasks/AtlasTask.java | 32 +- .../atlas/model/typedef/AtlasBaseTypeDef.java | 329 +++--- .../model/typedef/AtlasBusinessMetadataDef.java | 27 +- .../model/typedef/AtlasClassificationDef.java | 70 +- .../apache/atlas/model/typedef/AtlasEntityDef.java | 105 +- .../apache/atlas/model/typedef/AtlasEnumDef.java | 134 +-- .../atlas/model/typedef/AtlasRelationshipDef.java | 178 ++-- .../model/typedef/AtlasRelationshipEndDef.java | 88 +- .../apache/atlas/model/typedef/AtlasStructDef.java | 252 +++-- .../atlas/model/typedef/AtlasTypeDefHeader.java | 43 +- .../apache/atlas/model/typedef/AtlasTypesDef.java | 91 +- .../atlas/security/InMemoryJAASConfiguration.java | 162 ++- .../apache/atlas/security/SecurityProperties.java | 47 +- .../org/apache/atlas/security/SecurityUtil.java | 29 +- .../java/org/apache/atlas/type/AtlasArrayType.java | 243 +++-- .../org/apache/atlas/type/AtlasBuiltInTypes.java | 92 +- .../atlas/type/AtlasBusinessMetadataType.java | 38 +- .../apache/atlas/type/AtlasClassificationType.java | 542 +++++----- .../org/apache/atlas/type/AtlasEntityType.java | 969 +++++++++-------- .../java/org/apache/atlas/type/AtlasEnumType.java | 26 +- .../java/org/apache/atlas/type/AtlasMapType.java | 157 +-- .../apache/atlas/type/AtlasRelationshipType.java | 275 +++-- .../org/apache/atlas/type/AtlasStructType.java | 954 +++++++++-------- .../main/java/org/apache/atlas/type/AtlasType.java | 73 +- .../org/apache/atlas/type/AtlasTypeRegistry.java | 820 +++++++------- .../java/org/apache/atlas/type/AtlasTypeUtil.java | 284 +++-- .../java/org/apache/atlas/type/AttributeToken.java | 4 +- .../java/org/apache/atlas/type/ConstantToken.java | 2 +- .../main/java/org/apache/atlas/type/Constants.java | 35 +- .../java/org/apache/atlas/type/DependentToken.java | 9 +- .../apache/atlas/typesystem/types/DataTypes.java | 2 +- .../apache/atlas/utils/AtlasConfigurationUtil.java | 15 +- .../org/apache/atlas/utils/AtlasEntityUtil.java | 41 +- .../java/org/apache/atlas/utils/AtlasJson.java | 173 ++- .../org/apache/atlas/utils/AtlasStringUtil.java | 10 +- .../org/apache/atlas/utils/AuthenticationUtil.java | 16 +- .../org/apache/atlas/utils/FixedBufferList.java | 19 +- .../main/java/org/apache/atlas/utils/SSLUtil.java | 83 +- .../atlas/v1/model/discovery/DSLSearchResult.java | 46 +- .../v1/model/discovery/FullTextSearchResult.java | 46 +- .../v1/model/instance/AtlasSystemAttributes.java | 44 +- .../org/apache/atlas/v1/model/instance/Id.java | 179 ++-- .../atlas/v1/model/instance/Referenceable.java | 127 ++- .../org/apache/atlas/v1/model/instance/Struct.java | 94 +- .../v1/model/lineage/DataSetLineageResponse.java | 31 +- .../atlas/v1/model/lineage/LineageResponse.java | 32 +- .../atlas/v1/model/lineage/SchemaResponse.java | 39 +- .../model/notification/EntityNotificationV1.java | 84 +- .../v1/model/notification/HookNotificationV1.java | 42 +- .../v1/model/typedef/AttributeDefinition.java | 95 +- .../v1/model/typedef/ClassTypeDefinition.java | 21 +- .../atlas/v1/model/typedef/EnumTypeDefinition.java | 53 +- .../model/typedef/HierarchicalTypeDefinition.java | 30 +- .../atlas/v1/model/typedef/Multiplicity.java | 33 +- .../v1/model/typedef/StructTypeDefinition.java | 34 +- .../v1/model/typedef/TraitTypeDefinition.java | 17 +- .../apache/atlas/v1/model/typedef/TypesDef.java | 21 +- .../atlas/v1/typesystem/types/utils/TypesUtil.java | 53 +- .../apache/atlas/ApplicationPropertiesTest.java | 81 +- .../org/apache/atlas/TestRelationshipUtilsV2.java | 265 +++-- .../test/java/org/apache/atlas/TestUtilsV2.java | 1120 +++++++------------- .../java/org/apache/atlas/model/ModelTestUtil.java | 170 +-- .../model/instance/TestAtlasClassification.java | 15 +- .../atlas/model/instance/TestAtlasEntity.java | 24 +- .../typedef/TestAtlasBusinessMetadataDef.java | 40 +- .../model/typedef/TestAtlasClassificationDef.java | 22 +- .../atlas/model/typedef/TestAtlasEntityDef.java | 14 +- .../atlas/model/typedef/TestAtlasEnumDef.java | 18 +- .../model/typedef/TestAtlasRelationshipDef.java | 66 +- .../atlas/model/typedef/TestAtlasStructDef.java | 10 +- .../security/InMemoryJAASConfigurationTest.java | 61 +- ...AASConfigurationTicketBasedKafkaClientTest.java | 24 +- .../org/apache/atlas/type/TestAtlasArrayType.java | 90 +- .../apache/atlas/type/TestAtlasBigDecimalType.java | 26 +- .../apache/atlas/type/TestAtlasBigIntegerType.java | 24 +- .../apache/atlas/type/TestAtlasBooleanType.java | 27 +- .../type/TestAtlasBuiltInTypesFloatDouble.java | 12 +- .../org/apache/atlas/type/TestAtlasByteType.java | 30 +- .../atlas/type/TestAtlasClassificationType.java | 385 +++---- .../org/apache/atlas/type/TestAtlasDateType.java | 29 +- .../org/apache/atlas/type/TestAtlasDoubleType.java | 32 +- .../org/apache/atlas/type/TestAtlasEntityType.java | 440 ++++---- .../org/apache/atlas/type/TestAtlasFloatType.java | 33 +- .../org/apache/atlas/type/TestAtlasIntType.java | 28 +- .../org/apache/atlas/type/TestAtlasLongType.java | 29 +- .../org/apache/atlas/type/TestAtlasMapType.java | 72 +- .../apache/atlas/type/TestAtlasObjectIdType.java | 127 +-- .../atlas/type/TestAtlasRelationshipType.java | 152 ++- .../org/apache/atlas/type/TestAtlasShortType.java | 32 +- .../org/apache/atlas/type/TestAtlasStringType.java | 20 +- .../org/apache/atlas/type/TestAtlasStructType.java | 216 ++-- .../apache/atlas/type/TestAtlasTypeRegistry.java | 374 +++---- .../org/apache/atlas/type/TestMultiplicity.java | 11 +- .../apache/atlas/utils/FixedBufferListTest.java | 85 +- pom.xml | 22 +- .../org/apache/atlas/pc/StatusReporterTest.java | 36 +- .../org/apache/atlas/pc/WorkItemManagerTest.java | 14 +- .../atlas/pc/WorkItemManagerWithResultsTest.java | 41 +- 233 files changed, 10738 insertions(+), 10160 deletions(-) delete mode 100755 build-tools/src/main/resources/checkstyle.xml create mode 100644 dev-support/AtlasCodeScheme-IntelliJ.xml rename {build-tools/src/main/resources => dev-support}/checkstyle-suppressions.xml (76%) create mode 100755 dev-support/checkstyle.xml