(arrow) branch main updated: GH-47721: [C++][FlightRPC] Followup to remove unncessary std::move to resolve compliation flakiness (#48687)

[lidavidm]

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 1b0a220e03 GH-47721: [C++][FlightRPC] Followup to remove unncessary 
std::move to resolve compliation flakiness (#48687)
1b0a220e03 is described below

commit 1b0a220e03356d8b4c44e06a40fa1ddde6c81dc5
Author: Hyukjin Kwon <gurwls...@apache.org>
AuthorDate: Tue Dec 30 12:22:15 2025 +0900

    GH-47721: [C++][FlightRPC] Followup to remove unncessary std::move to 
resolve compliation flakiness (#48687)
    
    ### Rationale for this change
    
    Fixes compilation error on macOS: `-Wpessimizing-move` warning. 
`std::move()` on a ternary expression prevents copy elision. `shared_ptr` 
assignment already handles moves automatically, so `std::move` is unnecessary 
and hurts optimization.
    
    ### What changes are included in this PR?
    
    Removed `std::move()` from ternary expression in `ColumnMetadata` 
constructor (`cpp/src/arrow/flight/sql/column_metadata.cc:62`). Behavior 
unchanged - still ensures `metadata_map_` is never null.
    
    ### Are these changes tested?
    
    Yes. Existing tests cover `ColumnMetadata` functionality. No behavioral 
changes, so tests continue to pass.
    
    ### Are there any user-facing changes?
    
    No. Compilation fix only. Behavior identical, may have slight performance 
improvement from better compiler optimizations.
    * GitHub Issue: #47721
    
    Authored-by: Hyukjin Kwon <gurwls...@apache.org>
    Signed-off-by: David Li <li.david...@gmail.com>
---
 cpp/src/arrow/flight/sql/column_metadata.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpp/src/arrow/flight/sql/column_metadata.cc 
b/cpp/src/arrow/flight/sql/column_metadata.cc
index 6501e3c716..12b398e817 100644
--- a/cpp/src/arrow/flight/sql/column_metadata.cc
+++ b/cpp/src/arrow/flight/sql/column_metadata.cc
@@ -59,8 +59,8 @@ const char* ColumnMetadata::kRemarks = 
"ARROW:FLIGHT:SQL:REMARKS";
 
 ColumnMetadata::ColumnMetadata(
     std::shared_ptr<const arrow::KeyValueMetadata> metadata_map) {
-  metadata_map_ = std::move(metadata_map ? metadata_map
-                                         : 
std::make_shared<arrow::KeyValueMetadata>());
+  metadata_map_ =
+      metadata_map ? metadata_map : 
std::make_shared<arrow::KeyValueMetadata>();
 }
 
 arrow::Result<std::string> ColumnMetadata::GetCatalogName() const {