This is an automated email from the ASF dual-hosted git repository.
curth pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new ee5606971 chore(csharp): Update DuckDB (#3811)
ee5606971 is described below
commit ee5606971f6ae9baa56e1d5307da75d9ab86859f
Author: Curt Hagenlocher <[email protected]>
AuthorDate: Mon Dec 15 18:31:29 2025 -0800
chore(csharp): Update DuckDB (#3811)
Update to a newer version of DuckDB and the tests that broke with the
previous version.
---
csharp/Directory.Packages.props | 2 +-
csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs | 9 +--------
csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs | 9 +--------
3 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/csharp/Directory.Packages.props b/csharp/Directory.Packages.props
index 5e5b2f6da..6e4259dfc 100644
--- a/csharp/Directory.Packages.props
+++ b/csharp/Directory.Packages.props
@@ -31,7 +31,7 @@
<PackageVersion Include="Azure.Identity" Version="1.17.1" />
<PackageVersion Include="BenchmarkDotNet" Version="0.15.8" />
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
- <PackageVersion Include="DuckDB.NET.Bindings.Full" Version="1.4.1" />
+ <PackageVersion Include="DuckDB.NET.Bindings.Full" Version="1.4.3" />
<PackageVersion Include="K4os.Compression.LZ4" Version="1.3.8" />
<PackageVersion Include="K4os.Compression.LZ4.Streams" Version="1.3.8" />
<PackageVersion Include="Google.Cloud.BigQuery.Storage.V1"
Version="3.17.0" />
diff --git a/csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs
b/csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs
index d41b82aef..0e183ec1c 100644
--- a/csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs
+++ b/csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs
@@ -129,14 +129,7 @@ namespace Apache.Arrow.Adbc.Tests.Client
command.CommandText = "select ?, ?";
command.Prepare();
Assert.Equal(2, command.Parameters.Count);
- if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
- {
- Assert.Equal(string.Empty,
command.Parameters[0].ParameterName);
- }
- else
- {
- Assert.Equal("0", command.Parameters[0].ParameterName);
- }
+ Assert.Equal("0", command.Parameters[0].ParameterName);
Assert.Equal(DbType.Object, command.Parameters[0].DbType);
Assert.Equal("1", command.Parameters[1].ParameterName);
Assert.Equal(DbType.Object, command.Parameters[1].DbType);
diff --git a/csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs
b/csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs
index eeec6baa5..57525ed71 100644
--- a/csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs
+++ b/csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs
@@ -221,14 +221,7 @@ namespace Apache.Arrow.Adbc.Tests
statement.Prepare();
var schema = statement.GetParameterSchema();
Assert.Equal(2, schema.FieldsList.Count);
- if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
- {
- Assert.Equal(string.Empty, schema.FieldsList[0].Name);
- }
- else
- {
- Assert.Equal("0", schema.FieldsList[0].Name);
- }
+ Assert.Equal("0", schema.FieldsList[0].Name);
Assert.Equal(ArrowTypeId.Null,
schema.FieldsList[0].DataType.TypeId);
Assert.Equal("1", schema.FieldsList[1].Name);
Assert.Equal(ArrowTypeId.Null,
schema.FieldsList[1].DataType.TypeId);